Store config in local bucketing from config manager - #22
Merged
Conversation
| localBucketing.storeConfig(environmentKey, mapper.writeValueAsString(config)); | ||
| } catch (JsonProcessingException e) { | ||
| errorResponse.setMessage(e.getMessage()); | ||
| throw new DVCException(HttpResponseCode.byCode(500), errorResponse); |
Contributor
There was a problem hiding this comment.
this shouldn't be a 500 response code since its a parsing error and not an issue with the http request
Contributor
Author
There was a problem hiding this comment.
oh true, the DVCException requires a HttpResponseCode though - i guess i could drop that and throw the JsonProcessingException directly?
Contributor
There was a problem hiding this comment.
yup, we should also fall back to using the previous config (if available) and not erroring out the process
emmawillis
force-pushed
the
DVC-4206-config2
branch
from
September 8, 2022 14:59
0e71481 to
ee53fde
Compare
kaushalkapasi
approved these changes
Sep 8, 2022
emmawillis
force-pushed
the
DVC-4206-config2
branch
from
September 8, 2022 15:11
ee53fde to
0271f68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.