Release 26.06.6#9333
Merged
Merged
Conversation
Using `uv.sources` / `uv.index` does not work when publishing to pypi. Instead i forked coincurve master, published all the wheels as coincurve-cp314-fix v22 with fixes to make it work on python 3.14 Changelog-None
A v1 channel_id is derived solely from the funding outpoint, so two channels funded by the same outpoint would share a channel_id. When a peer completes a second funding using an outpoint we already have a channel for, refuse it and drop the connection instead of committing a second channel with a colliding channel_id. Add find_channel_by_funding_outpoint() to look up an existing channel by its funding outpoint.
peer_connect_subd asserted that the subd had no connection yet. Replace that assertion with defensive handling: if a connection is already attached for this channel_id, keep it and close the incoming fd. This avoids aborting connectd in the unexpected case where a second fd arrives for a subd that already has one.
noble builds were failing because of a missing aclocal usual recommendation is to install automake which apparently no longer is in the dependency graph for noble we add it to all ubuntu images in case it gets removed in jammy/resolute as well Changelog-None
…lute Switch `Dockerfile.noble` and `Dockerfile.resolute` to noble / resolute to match the debootstrap-based minimal image approach.
… argument The sign target detection uses pattern matching that requires spaces on both sides of "sign" in the TARGETS variable. When only "sign" is passed as an argument, TARGETS becomes " sign" (leading space only), causing the condition to fail. Add an additional pattern match to detect "sign" with a leading space but no trailing space, which occurs when "sign" is the only target or the last target in the list. This regression seems to have been exposed by GitHub Actions runner updates (Ubuntu 22.04 → 24.04), which changed argument passing behavior. Changelog-None: Fixes the release signing issue in CI only.
… target Pass the computed VERSION as a build-arg, mirroring the docker-release workflow. Without it the container's VERSION is set-but-empty, `VERSION ?=` in the Makefile won't overwrite it, the git-describe fallback never runs, and `make install-program` fails with "git is required for generating version information". Also add --no-push, so a release captain can do a full test build without publishing elementsproject/lightningd:$VERSION and :latest (the target always runs `docker buildx build --push`, since multi-arch images cannot be --load'ed into the classic docker store). The build only populates the builder's cache; a subsequent run without the flag pushes from cache quickly. Co-Authored-By: Claude <claude@users.noreply.github.com>
cdecker
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also included all the build script/Dockerfile fixes to get things working properly.
Changelog-None