Skip to content

Moving files and folders a little - #4

Merged
AndrewGable merged 4 commits into
masterfrom
tgolen-async-promise
Aug 8, 2020
Merged

Moving files and folders a little#4
AndrewGable merged 4 commits into
masterfrom
tgolen-async-promise

Conversation

@tgolen

@tgolen tgolen commented Aug 8, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@tgolen
tgolen requested a review from AndrewGable August 8, 2020 15:53
@tgolen tgolen self-assigned this Aug 8, 2020
@AndrewGable

Copy link
Copy Markdown
Contributor

I saw this error when running on iOS:

jest-haste-map: Watchman crawl failed. Retrying once with node crawler.
  Usually this happens when watchman isn't running. Create an empty `.watchmanconfig` file in your project's root folder or initialize a git or hg repository in your project.
  Error: Watchman error: resolve_projpath: path `./src`: open: ./src: No such file or directory. Make sure watchman is running for this project. See https://facebook.github.io/watchman/docs/troubleshooting.html.
Error: Expected file to be absolute path but got ./src/.
    at new Module (/Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/node-haste/Module.js:17:13)
    at ModuleCache.getModule (/Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/node-haste/ModuleCache.js:26:37)
    at DependencyGraph.resolveDependency (/Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/node-haste/DependencyGraph.js:287:52)
    at /Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/lib/transformHelpers.js:267:42
    at Server.<anonymous> (/Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/Server.js:841:41)
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/Server.js:99:24)
    at _next (/Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/Server.js:119:9)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

Comment thread metro.config.js Outdated
},
}),
},
projectRoot: './src',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this line and it will actually work just fine

@tgolen

tgolen commented Aug 8, 2020

Copy link
Copy Markdown
Contributor Author

Updated to remove the projectRoot option

@AndrewGable
AndrewGable merged commit 7779fa9 into master Aug 8, 2020
@AndrewGable
AndrewGable deleted the tgolen-async-promise branch August 8, 2020 16:21
marcaaron pushed a commit that referenced this pull request Feb 22, 2021
AndrewGable pushed a commit that referenced this pull request Mar 4, 2021
Julesssss pushed a commit that referenced this pull request Apr 7, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

stitesExpensify pushed a commit that referenced this pull request Oct 28, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @AndrewGable in version: 1.1.10-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.11-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@MelvinBot MelvinBot mentioned this pull request Jul 3, 2026
52 tasks
x-dev90 pushed a commit to x-dev90/App that referenced this pull request Jul 10, 2026
Fixes APP-B2Q error Expensify#4: '[createDynamicRoute] Query param reportID exists in
both base path and dynamic suffix'. mergeQueryStrings threw whenever a key
appeared in both the base path (active route) and the dynamic suffix, even when
both carried the same value. On HybridApp the restored active route can already
hold ?reportID=R1, so re-emitting the same reportID from a dynamic route threw.
Now it only throws when the values actually differ, and collapses identical
duplicates into one param.

Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants