Test ad-hoc build cache for #97110 - #97672
Conversation
Trivial, visible UI change to verify ad-hoc builds pick up new commits. Related to #97110.
![chatgpt-codex-connector[bot]](https://cdn.github.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a52d86d1bc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| dangerPressed: colors.redHover, | ||
| warning: colors.yellow400, | ||
| success: colors.green400, | ||
| success: colors.blue400, |
There was a problem hiding this comment.
If this commit is merged, light-theme users get the global theme.success token as blue while the rest of the success palette still stays green (successHover, successPressed, dark theme, and components like styles.buttonSuccess/badgeSuccessStrong all assume this semantic is green). Since this token is used across success buttons, status indicators, selected states, and Onfido theming, the ad-hoc-build probe would ship a broad production UI regression rather than a test-only marker.
Useful? React with 👍 / 👎.
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
…le-code' into test-adhoc-build-97110
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
2 participants
Purpose
Testing PR for #97110 — Web ad-hoc builds serve stale code (v2 shows v1's changes).
Trivial, visible UI change (success/green color swapped to blue) so a build change is easy to eyeball. Plan: trigger an ad-hoc build, push another commit changing the color again, trigger a second ad-hoc build, and confirm it reflects the new commit instead of serving the previous build's output.
Not intended to merge.
Test plan