Skip to content

Fix report history showing the workspace's current bank account instead of the reimbursement's actual bank account - #97707

Draft
x-dev90 wants to merge 1 commit into
Expensify:mainfrom
x-dev90:fix/report-history-reimbursement-bank-account
Draft

Fix report history showing the workspace's current bank account instead of the reimbursement's actual bank account#97707
x-dev90 wants to merge 1 commit into
Expensify:mainfrom
x-dev90:fix/report-history-reimbursement-bank-account

Conversation

@x-dev90

@x-dev90 x-dev90 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Previously, report history could show the workspace’s current reimbursement bank account instead of the bank account that was actually used when the report was paid. This made older reimbursement history look like it changed after the workspace bank account was updated.

This change makes the report history and related report/thread title use the bank account snapshot stored on the original payment action first. If that snapshot is not available, the app still falls back to the existing current-policy account behavior for older data.

Fixed Issues

$ #96680
PROPOSAL: #96680 (comment)

Tests

  1. Use a workspace with reimbursement bank account A configured.
  2. Create and approve an expense report.
  3. Pay/reimburse the report using Expensify with bank account A.
  4. Open the report history and confirm the reimbursement message shows bank account A’s last four digits.
  5. Change the workspace reimbursement bank account to bank account B.
  6. Reopen the previously reimbursed report.
  7. Verify the historical reimbursement message still shows bank account A’s last four digits.
  8. Open the reimbursement action thread or any view that displays the payment action as the report/thread name.
  9. Verify it also still shows bank account A’s last four digits, not bank account B’s.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
Screenshot_20260803_231335_Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant