Skip to content

build: upgrade lombok to 1.18.40 with support for Java 25 - #71

Merged
paodb merged 1 commit into
masterfrom
lombok-1.18.40
Jul 27, 2026
Merged

build: upgrade lombok to 1.18.40 with support for Java 25#71
paodb merged 1 commit into
masterfrom
lombok-1.18.40

Conversation

@javier-godoy

@javier-godoy javier-godoy commented Jul 27, 2026

Copy link
Copy Markdown
Member

See https://github.com/FlowingCode/AddonsInternal/issues/202

Summary by CodeRabbit

  • Chores
    • Updated build tooling and code-generation support to newer versions.
    • Improved project compilation configuration for Lombok-based features.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Updates the Maven Lombok version and configures maven-compiler-plugin annotation processing with Lombok.

Changes

Lombok build configuration

Layer / File(s) Summary
Compiler and Lombok processing configuration
pom.xml
Updates Lombok to 1.18.40 and configures maven-compiler-plugin 3.13.0 with Lombok annotation processing.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: flowingcodeci

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely matches the main change: upgrading Lombok to 1.18.40 with Java 25 support.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lombok-1.18.40

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pom.xml`:
- Around line 180-193: Declare org.apache.maven.plugins:maven-compiler-plugin
under the active build plugins section, reusing the managed configuration so the
Lombok annotationProcessorPaths are applied during compilation. Keep the
existing pluginManagement entry unchanged unless needed to avoid duplicating
configuration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: faf157c3-915c-49a3-bc82-e2929aa6732f

📥 Commits

Reviewing files that changed from the base of the PR and between 9345695 and 55b50a4.

📒 Files selected for processing (1)
  • pom.xml

Comment thread pom.xml
@javier-godoy
javier-godoy requested a review from paodb July 27, 2026 19:56
@javier-godoy
javier-godoy marked this pull request as ready for review July 27, 2026 19:56
@javier-godoy
javier-godoy requested a review from scardanzan July 27, 2026 19:57
@paodb
paodb merged commit 718e2cb into master Jul 27, 2026
5 checks passed
@paodb
paodb deleted the lombok-1.18.40 branch July 27, 2026 21:02
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

2 participants