Skip to content

fix: improve ACP model selection and setup copy - #1848

Open
wgqqqqq wants to merge 2 commits into
mainfrom
fix/acp-agents-install-copy
Open

fix: improve ACP model selection and setup copy#1848
wgqqqqq wants to merge 2 commits into
mainfrom
fix/acp-agents-install-copy

Conversation

@wgqqqqq

@wgqqqqq wgqqqqq commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Surface provider names and session model details for ACP model selection so choices are distinguishable.
  • Clarify self-managed ACP setup when the CLI is missing, with separate config and install instructions.
  • Add focused tests and localized copy updates.

Fixes #1782

Type and Areas

Type:

  • Bug fix
  • UI/UX
  • test
  • i18n

Areas:

  • Rust ACP interface
  • Web UI
  • Locales

Motivation / Impact

ACP model selection now shows provider-qualified options where available. The ACP agent setup screen also makes the config-added state and the install-CLI step explicit for self-managed clients.

Verification

  • pnpm --dir src/web-ui run test:run src/flow_chat/utils/acpSessionConfig.test.ts
  • pnpm --dir src/web-ui run test:run src/infrastructure/config/components/AcpAgentsConfig.test.tsx
  • pnpm run type-check:web
  • cargo check --workspace
  • pnpm run i18n:audit

Reviewer Notes

The repo-hygiene failure was caused by a generated scratch file and is no longer present in the PR.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

@wgqqqqq wgqqqqq changed the title fix: clarify ACP agents install flow fix: clarify ACP agents setup copy Jul 29, 2026
@wgqqqqq
wgqqqqq force-pushed the fix/acp-agents-install-copy branch from 54e3e32 to 8f3bea9 Compare July 29, 2026 07:35
@wgqqqqq wgqqqqq changed the title fix: clarify ACP agents setup copy fix: improve ACP model selection and setup copy Jul 29, 2026
@wgqqqqq
wgqqqqq force-pushed the fix/acp-agents-install-copy branch from 8f3bea9 to b86ace5 Compare July 29, 2026 08:00
…all-copy

# Conflicts:
#	src/web-ui/src/flow_chat/components/ModelSelector.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: acp的model选择注释provider

1 participant