chore: replace always-on 429 retry with opt-in RetryConfig - #56
Merged
Conversation
The client no longer retries HTTP 429 responses automatically. Add RetryConfig (disabled by default) and ClientBuilder::retry() to opt in. When enabled, only GET/HEAD requests retry on 429 (unless unrecoverable) or a transport error, honoring Retry-After and otherwise backing off exponentially with full jitter, both capped at maxBackoff. A DEBUG http.request.failed event with a retry.attempt field is emitted before each retry; the existing ERROR-level event for a surfaced transport failure is unchanged. GuzzleHttpClient's $maxRetries constructor param is now deprecated and ignored, kept only for positional-call compatibility.
…ited error.type is a closed transport-failure enum (connection_reset | timeout | dns_failure | tls_handshake_failed | unknown). A 429 is a received response, not a transport failure, so emitRetryAttempt no longer fabricates a rate_limited value for it; the field is only set when the retried error is a StreamTransportException.
testHardDeleteChannels waits on an async hard-delete task, but under shared-backend async-queue latency it can miss the 120-attempt poll window and fail. Add an opt-in skipOnTimeout to waitForTask so the hard-delete test skips rather than fails on timeout, mirroring the getstream-go fix; a genuine task failure still surfaces as status 'failed', and other callers keep the default fail-on-timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://linear.app/stream/issue/CHA-2959/rate-limits-and-retry
Summary
Adds an opt-in auto-retry policy.
RetryConfigis disabled by default (maxAttempts=3,maxBackoff=30s). When enabled, retries ONLYGET/HEADrequests that fail with HTTP 429 or a transport error, honoringRetry-After(clamped tomaxBackoff) otherwise exponential backoff with full jitter. Never retries writes or 5xx; always honors the backendunrecoverableflag; surfaces the last attempt's error. Config surface:ClientBuilder::retry(new RetryConfig(...))Notes
RetryConfig.http.request.failedlog event with aretry.attemptfield (transport retries carryerror.type; 429 retries omit it, since that field is the transport-only enum).chore:intentionally so the merge does not auto-publish (despite the breaking change). Publish later via the manual Release workflow; the release notes should flag the breaking behavior change.