Skip to content

统一管理页面工具栏 下载 按钮文案 - #6499

Open
CiiLu wants to merge 1 commit into
HMCL-dev:mainfrom
CiiLu:catt
Open

统一管理页面工具栏 下载 按钮文案#6499
CiiLu wants to merge 1 commit into
HMCL-dev:mainfrom
CiiLu:catt

Conversation

@CiiLu

@CiiLu CiiLu commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

原先世界管理的是 “下载世界”,而模组管理和资源包管理的是 “下载”

@github-actions github-actions Bot added the 10+ label Jul 25, 2026
@Glavo

Glavo commented Jul 25, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b80cf42114

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

control.checkUpdates(listView.getItems().stream().map(ResourcePackInfoObject::getFile).toList())
),
createToolbarButton2(i18n("download"), SVG.DOWNLOAD, control::onDownload),
createToolbarButton2(i18n("resourcepack.download"), SVG.DOWNLOAD, control::onDownload),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add localized resource-pack download labels

Add resourcepack.download to the Spanish, Japanese, Russian, and Ukrainian bundles before using it here. Those shipped bundles contain localized download values but lack this key, so ResourceBundle falls back to the base bundle and the toolbar changes from localized text such as “Descargar” or “ダウンロード” to English “Download” for users of those four languages.

Useful? React with 👍 / 👎.

mods.add.title=選取要新增的模組檔案
mods.disable=停用
mods.download=模組下載
mods.download=下载模组

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the Traditional Chinese translation in traditional script

Use Traditional Chinese characters for this bundle, such as 下載模組. I18N_zh.properties is the Traditional Chinese resource and its neighboring strings use forms such as 新增, 停用, and 模組下載; the new 下载模组 mixes Simplified Chinese into that UI.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants