Skip to content

Use workflow result for commit style - #23402

Open
MikeMcQuaid wants to merge 1 commit into
mainfrom
replace-commit-status
Open

Use workflow result for commit style#23402
MikeMcQuaid wants to merge 1 commit into
mainfrom
replace-commit-status

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member

Needs Homebrew/actions#905

  • Drop the status write that fork pull requests cannot receive.
  • Pin the action version for now that fails the workflow on validation errors.
  • Report the required check for synthetic merge queue commits.

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

OpenAI GPT 5.6 sol xhigh with local review.


- Drop the status write that fork pull requests cannot receive.
- Pin the action version that fails the workflow on validation errors.
- Report the required check for synthetic merge queue commits.
Copilot AI review requested due to automatic review settings August 3, 2026 07:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Commit Style GitHub Actions workflow to rely on the workflow/job result as the required check (instead of writing commit statuses), and to run for merge queue (“merge_group”) events so synthetic merge commits still receive the required check result.

Changes:

  • Add merge_group as a trigger so the workflow runs for merge-queue commits.
  • Remove statuses: write permission and stop passing an explicit token to avoid status writes that fork PRs can’t receive.
  • Pin Homebrew/actions/check-commit-format to a specific commit SHA (updated pin).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- name: Check commit format
uses: Homebrew/actions/check-commit-format@9af03b7ae3f9e2ae5c174f659d5c3909f7e7dbac # 2026.07.29.1
if: github.event_name == 'pull_request'
uses: Homebrew/actions/check-commit-format@b5fe8cf83919304b3300e0607a2538d40b8749ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants