Skip to content

audit: deprecate requirements in core - #9052

Merged
MikeMcQuaid merged 2 commits into
Homebrew:masterfrom
jonchang:deprecate-requirements-in-core
Nov 6, 2020
Merged

audit: deprecate requirements in core#9052
MikeMcQuaid merged 2 commits into
Homebrew:masterfrom
jonchang:deprecate-requirements-in-core

Conversation

@jonchang

@jonchang jonchang commented Nov 5, 2020

Copy link
Copy Markdown
Contributor

This strict audit ensures that new formulae that depend on Requirements like :x11, :java, and :osxfuse are not introduced into homebrew/core.

cc @homebrew/core

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This strict audit ensures that new formulae that depend on Requirements
like :x11, :java, and :osxfuse are not introduced into homebrew/core.
@jonchang jonchang added discussion Input solicited from others do not merge labels Nov 5, 2020
@MikeMcQuaid

Copy link
Copy Markdown
Member
  • :x11 formulae can now be migrated over to e.g. depends_on "libx11". No tracking issue yet as there are some things that still need to be worked out, but an example migration is here: Homebrew/homebrew-core#64165

Wow, I didn't know that was now a thing. Great work everyone involved with this 👏🏻

Comment thread Library/Homebrew/rubocops/lines.rb
Comment thread Library/Homebrew/rubocops/lines.rb
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@MikeMcQuaid
MikeMcQuaid merged commit 0793644 into Homebrew:master Nov 6, 2020
@MikeMcQuaid

Copy link
Copy Markdown
Member

Thanks @jonchang!

@jonchang
jonchang deleted the deprecate-requirements-in-core branch November 6, 2020 21:14
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

discussion Input solicited from others outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants