audit: deprecate requirements in core - #9052
Merged
MikeMcQuaid merged 2 commits intoNov 6, 2020
Merged
Conversation
This strict audit ensures that new formulae that depend on Requirements like :x11, :java, and :osxfuse are not introduced into homebrew/core.
Member
Wow, I didn't know that was now a thing. Great work everyone involved with this 👏🏻 |
MikeMcQuaid
reviewed
Nov 5, 2020
MikeMcQuaid
reviewed
Nov 5, 2020
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
MikeMcQuaid
approved these changes
Nov 5, 2020
SMillerDev
approved these changes
Nov 5, 2020
Member
|
Thanks @jonchang! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This strict audit ensures that new formulae that depend on Requirements like :x11, :java, and :osxfuse are not introduced into homebrew/core.
:javaformulae were mostly migrated over to the brewed version earlier this year. The only remaining formulae are for Java 1.8, which is being tracked here: openjdk@8 migration tracking issue homebrew-core#63290:x11formulae can now be migrated over to e.g.depends_on "libx11". x11 migration tracking issue homebrew-core#64166:osxfuseformulae will need to be disabled or deleted, as the licensing has changed and there is no longer a way to build it from source anyway. The versions that could theoretically be built from source and distributed with Homebrew will soon not work on supported macOS versions. Deprecate FUSE formulae. homebrew-core#64491cc @homebrew/core
brew stylewith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?