Skip to content

Fix/cookie assistant for custom network #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aarmoa merged 2 commits into from
Aug 30, 2023
Merged

Fix/cookie assistant for custom network #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a63cb1
(fix) Made cookie_assistant parameter optional when creating a custom…
Aug 30, 2023
9918722
(fix) Updated README.md Changelogs with the latest changes
Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ make tests
* The Composer can still be instantiated without markets and tokens. When markets and tokens are not provided the Composer loads the required information from the Denoms used in previous versions
* Change in AsyncClient to be able to create Composer instances for the client network, markets and tokens
* Examples have been adapted to create Composer instances using the AsyncClient
* Added new nodes (bare-metal load balancing nodes) for mainnet
* Refactored the cookies management logic into a cookie assistant. Added the required logic to support the new cookies format for bare-metal load balanced nodes

**0.7.1.1**
* Fixed Testnet network URLs
Expand Down
5 changes: 3 additions & 2 deletions pyinjective/core/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,8 +370,9 @@ def custom(
grpc_explorer_endpoint,
chain_id,
env,
cookie_assistant: CookieAssistant,
cookie_assistant: Optional[CookieAssistant] = None,
):
assistant = cookie_assistant or DisabledCookieAssistant()
return cls(
lcd_endpoint=lcd_endpoint,
tm_websocket_endpoint=tm_websocket_endpoint,
Expand All @@ -381,7 +382,7 @@ def custom(
chain_id=chain_id,
fee_denom="inj",
env=env,
cookie_assistant=cookie_assistant
cookie_assistant=assistant
)

def string(self):
Expand Down