feat: add MsgPrivilegedExecuteContract, MsgInstantiateContract composer - #247
Merged
Conversation
aarmoa
suggested changes
Sep 14, 2023
aarmoa
left a comment
aarmoa
left a comment
Contributor
There was a problem hiding this comment.
The changes look good to me, but we can't merge a PR to master without updating the version number in setup.py and also updating the changelog in the README.md file clarifying the change being done.
Was the intention to point to master of was it to point to dev branch.
I have added a couple of comments to complete the missing type hints.
| proposal_id=proposal_id, voter=voter, option=option | ||
| ) | ||
|
|
||
| def MsgPrivilegedExecuteContract(self, sender: str, contract: str, msg: str, **kwargs): |
Contributor
There was a problem hiding this comment.
Please add the type hint for the return value of the function
| funds=kwargs.get('funds') # funds is a string of Coin strings, comma separated, e.g 100000inj,20000000000usdt | ||
| ) | ||
|
|
||
| def MsgInstantiateContract(self, sender, admin: str, code_id: int, label: str, message: bytes, **kwargs): |
Contributor
There was a problem hiding this comment.
Please add the type hint to the sender param and also to the return value of the function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We might need this to interact with offchain vaults (and more contracts in the future!)
Example in this PR:
https://github.com/InjectiveLabs/sdk-python/pull/246/files