Feat/update gas cost in gas estimator - #299
Merged
Merged
Conversation
aarmoa
commented
Jan 25, 2024
aarmoa
commented
Contributor
- Updated reference gas cost for all messages in the gas estimator
- Included different calculation for Post Only orders
- Updated all proto definitions for Injective Core 1.12.1
added 6 commits
January 23, 2024 16:39
…pendencies to version 1.12.1
… issues when using the estimator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 72.97% 73.06% +0.09%
==========================================
Files 48 48
Lines 3404 3416 +12
Branches 303 304 +1
==========================================
+ Hits 2484 2496 +12
Misses 839 839
Partials 81 81 ☔ View full report in Codecov by Sentry. |
nicolasbaum
approved these changes
Jan 25, 2024
nicolasbaum
left a comment
nicolasbaum
left a comment
There was a problem hiding this comment.
New Gas Limit constants seem ok and gas multiplier 1.5 for post limit orders suits the chain gas comsumption
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.