-
Notifications
You must be signed in to change notification settings - Fork 34
Fix/remove deprecated methods from examples #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -157,7 +157,7 @@ def test_estimation_for_batch_update_orders_to_create_spot_orders(self): | |||||||
| order_type="BUY", | ||||||||
| ), | ||||||||
| ] | ||||||||
| message = composer.MsgBatchUpdateOrders( | ||||||||
| message = composer.msg_batch_update_orders( | ||||||||
| sender="senders", | ||||||||
| derivative_orders_to_create=[], | ||||||||
| spot_orders_to_create=orders, | ||||||||
|
|
@@ -194,7 +194,7 @@ def test_estimation_for_batch_update_orders_to_create_derivative_orders(self): | |||||||
| order_type="SELL", | ||||||||
| ), | ||||||||
| ] | ||||||||
| message = composer.MsgBatchUpdateOrders( | ||||||||
| message = composer.msg_batch_update_orders( | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The method call - sender="senders",
+ sender="sender",Committable suggestion
Suggested change
|
||||||||
| sender="senders", | ||||||||
| derivative_orders_to_create=orders, | ||||||||
| spot_orders_to_create=[], | ||||||||
|
|
@@ -249,7 +249,7 @@ def test_estimation_for_batch_update_orders_to_create_binary_orders(self, usdt_t | |||||||
| order_type="SELL", | ||||||||
| ), | ||||||||
| ] | ||||||||
| message = composer.MsgBatchUpdateOrders( | ||||||||
| message = composer.msg_batch_update_orders( | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The method call - sender="senders",
+ sender="sender",Committable suggestion
Suggested change
|
||||||||
| sender="senders", | ||||||||
| derivative_orders_to_create=[], | ||||||||
| spot_orders_to_create=[], | ||||||||
|
|
@@ -284,7 +284,7 @@ def test_estimation_for_batch_update_orders_to_cancel_spot_orders(self): | |||||||
| order_hash="0x7ee76255d7ca763c56b0eab9828fca89fdd3739645501c8a80f58b62b4f76da5", | ||||||||
| ), | ||||||||
| ] | ||||||||
| message = composer.MsgBatchUpdateOrders( | ||||||||
| message = composer.msg_batch_update_orders( | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The method call - sender="senders",
+ sender="sender",Committable suggestion
Suggested change
|
||||||||
| sender="senders", | ||||||||
| derivative_orders_to_create=[], | ||||||||
| spot_orders_to_create=[], | ||||||||
|
|
@@ -318,7 +318,7 @@ def test_estimation_for_batch_update_orders_to_cancel_derivative_orders(self): | |||||||
| order_hash="0x7ee76255d7ca763c56b0eab9828fca89fdd3739645501c8a80f58b62b4f76da5", | ||||||||
| ), | ||||||||
| ] | ||||||||
| message = composer.MsgBatchUpdateOrders( | ||||||||
| message = composer.msg_batch_update_orders( | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The method call - sender="senders",
+ sender="sender",Committable suggestion
Suggested change
|
||||||||
| sender="senders", | ||||||||
| derivative_orders_to_create=[], | ||||||||
| spot_orders_to_create=[], | ||||||||
|
|
@@ -352,7 +352,7 @@ def test_estimation_for_batch_update_orders_to_cancel_binary_orders(self): | |||||||
| order_hash="0x7ee76255d7ca763c56b0eab9828fca89fdd3739645501c8a80f58b62b4f76da5", | ||||||||
| ), | ||||||||
| ] | ||||||||
| message = composer.MsgBatchUpdateOrders( | ||||||||
| message = composer.msg_batch_update_orders( | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The method call - sender="senders",
+ sender="sender",Committable suggestion
Suggested change
|
||||||||
| sender="senders", | ||||||||
| derivative_orders_to_create=[], | ||||||||
| spot_orders_to_create=[], | ||||||||
|
|
@@ -371,7 +371,7 @@ def test_estimation_for_batch_update_orders_to_cancel_all_for_spot_market(self): | |||||||
| market_id = "0x0611780ba69656949525013d947713300f56c37b6175e02f26bffa495c3208fe" | ||||||||
| composer = Composer(network="testnet") | ||||||||
|
|
||||||||
| message = composer.MsgBatchUpdateOrders( | ||||||||
| message = composer.msg_batch_update_orders( | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The method call - sender="senders",
+ sender="sender",Committable suggestion
Suggested change
|
||||||||
| sender="senders", | ||||||||
| subaccount_id="subaccount_id", | ||||||||
| spot_market_ids_to_cancel_all=[market_id], | ||||||||
|
|
@@ -391,7 +391,7 @@ def test_estimation_for_batch_update_orders_to_cancel_all_for_derivative_market( | |||||||
| market_id = "0x0611780ba69656949525013d947713300f56c37b6175e02f26bffa495c3208fe" | ||||||||
| composer = Composer(network="testnet") | ||||||||
|
|
||||||||
| message = composer.MsgBatchUpdateOrders( | ||||||||
| message = composer.msg_batch_update_orders( | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The method call - sender="senders",
+ sender="sender",Committable suggestion
Suggested change
|
||||||||
| sender="senders", | ||||||||
| subaccount_id="subaccount_id", | ||||||||
| derivative_market_ids_to_cancel_all=[market_id], | ||||||||
|
|
@@ -411,7 +411,7 @@ def test_estimation_for_batch_update_orders_to_cancel_all_for_binary_options_mar | |||||||
| market_id = "0x0611780ba69656949525013d947713300f56c37b6175e02f26bffa495c3208fe" | ||||||||
| composer = Composer(network="testnet") | ||||||||
|
|
||||||||
| message = composer.MsgBatchUpdateOrders( | ||||||||
| message = composer.msg_batch_update_orders( | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The method call - sender="senders",
+ sender="sender",Committable suggestion
Suggested change
|
||||||||
| sender="senders", | ||||||||
| subaccount_id="subaccount_id", | ||||||||
| binary_options_market_ids_to_cancel_all=[market_id], | ||||||||
|
|
@@ -440,7 +440,7 @@ def test_estimation_for_exec_message(self): | |||||||
| order_type="BUY", | ||||||||
| ), | ||||||||
| ] | ||||||||
| inner_message = composer.MsgBatchUpdateOrders( | ||||||||
| inner_message = composer.msg_batch_update_orders( | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The method call - sender="senders",
+ sender="sender",Committable suggestion
Suggested change
|
||||||||
| sender="senders", | ||||||||
| derivative_orders_to_create=[], | ||||||||
| spot_orders_to_create=orders, | ||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method call
composer.msg_batch_update_orderscorrectly replaces the deprecated method name. This change aligns with the PR's objective to update example scripts and test files to use current method names. However, there's a minor typo in thesenderparameter value ("senders" should be "sender").Committable suggestion