SteelTrapDeathPatch - #333
Conversation
* Implements the SteelTrapDeathPatch, which is made by Snowi and SpecialAPI. * Change to `netframework4.7.2` (closer to the Runtime netframework.) * Better NoWarns * Implement `GetSteelTrapPelt` and `SetSteelTrapPelt` card extensions * Upgrade to API 2.24.0 * Add a Test Case related to the new patch. * Update README and CHANGELOG
* Update NuGet.Config * Upgrade Dependencies * Add some more warnings to the NoWarn
HumabHatterZed
left a comment
HumabHatterZed
left a comment
There was a problem hiding this comment.
Looks good, though I do request that you revert the changes to the changelog file; I have some stuff I'm doing on my end and want to avoid merge conflicts (also I'd like the changelog to have a consistent format but that's a me thing). I guess we could also just merge this one then I can update it on my end so whatever.
I am personally curious why you've opted to update the target framework - is there any specific reason or is it just for the sake of being more up-to-date?
IIRC the framework change was mainly so its closer to runtime so certain patching related matters can work properly without needing additional libraries for things included in framework 2.0 Also Yeah I can clear up the Changelog changes (since they are in the commit desc and stuff anywho) one momento |
2 participants
netframework4.7.2(closer to the Runtime netframework.)GetSteelTrapPeltandSetSteelTrapPeltcard extensions