Support JET@0.12 in tests - #993
Merged
Merged
Conversation
devmotion
force-pushed
the
dmw/jet_0-11
branch
from
January 11, 2026 23:00
8bbfd0d to
66cd08a
Compare
devmotion
force-pushed
the
dmw/jet_0-11
branch
from
January 12, 2026 16:40
66cd08a to
cad757e
Compare
JET 0.11 re-executes a package's top-level code via Revise to extract method signatures, which re-expands the `IrrationalConstants.@irrational` macro. IrrationalConstants >= 0.2.6 throws at macro-expansion time when the generated type already exists, so the re-expansion errored in the JET tests. Wrap the definition in `@static if !isdefined(...)` so it is idempotent under re-expansion. `@static` only macroexpands the chosen branch, so the macro is skipped once the type exists (a runtime `if` would not help, since both branches are macroexpanded). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
devmotion
enabled auto-merge (squash)
June 17, 2026 08:51
nalimilan
approved these changes
Jul 29, 2026
|
|
||
| # Default error analysis for common problem fails since JET errors on interface definitions | ||
| # Default error analysis | ||
| # Note: This analysis is not enough strict to guarantee that there are no runtime errors! |
Member
There was a problem hiding this comment.
Suggested change
| # Note: This analysis is not enough strict to guarantee that there are no runtime errors! | |
| # Note: This analysis is not strict enough to guarantee that there are no runtime errors! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #980. Supersedes #1005.
Closes #980. Closes #1005.