Conversation
This add's a '-t' flag that can be either 'aws' or 'rax' (defaults to 'aws). Basically we just refactor the Proxy() object into AWSProxy and RAXProxy objects which are generated based on the -t flag. These just overwrite methods that convert a config section into a POST-able dictionary that is consistent with the correct profile schema.
This follows the AWS endpoints pretty closely.
Implements get_cluster_body() on RAXProxy inside the integration framework. This also introduces a [default] section with a single key/value pair 'type' which can be one of 'aws' or 'rax.' By default this is 'aws.' However, if specified in the configuration you do not have to pass the '-t' or '--type' flag to specify that you are working with a RAXProxy rather than a AWSProxy object. Finally this also ignores rax.cfg in the tests/integration directory allowing you to create a custom rax script for testing.
This does not implement logic for launching clusters, it just adds the 'rax' ClusterType and code for creating a rax cluster model. This follows the same format as an ec2 cluster (because both will use ansible). Eventually we will want to try and merge these two code paths for creating clusters (as they contain a great deal of duplicate code and are using the same underlying system - ansible).
Various cloud providers need (or should have) different information available in the executing environment. This helps generalize the the launch/provision/terminate celery tasks.
Various cloud providers each need to provide different extra variable to their playbooks, this allows those differences to be encapsulated in the respective CloudProvider classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.