chore(*): remove sample access key from SDK documentation - #102
Merged
Tieske merged 8 commits intoFeb 27, 2024
Conversation
Collaborator
Author
|
Member
|
I'm considering whether removing all the document fields is a good idea since we don't actually need those things and that could probably also help us maintain smaller JSON files |
Tieske
reviewed
Feb 13, 2024
Co-authored-by: Thijs Schreijer <thijs@thijsschreijer.nl>
Collaborator
Author
|
@windmgc we can do it. But I try to minimize the change for this case. |
windmgc
previously approved these changes
Feb 27, 2024
Tieske
previously approved these changes
Feb 27, 2024
Tieske
left a comment
Contributor
There was a problem hiding this comment.
please add a chaneglog entry before merging
Tieske
reviewed
Feb 27, 2024
Co-authored-by: Thijs Schreijer <thijs@thijsschreijer.nl>
Tieske
approved these changes
Feb 27, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In the AWS SDK, there is sample access key sample
wJalrXUtnFEMIthat may trigger CVE report. This PR tries to remove it.This is a dangerous operation! Before merge, we must ensure only the access key sample is removed!
FTI-5732 FTI-5732