fix(cargo-deny): ignore unmaintained transitive advisories with rationale - #8
Conversation
…nale - Add 4 ignore entries for bincode 1.x (RUSTSEC-2025-0141), paste (2024-0436), rustls-pemfile (2025-0134), yaml-rust (2024-0320) — all transitive via upstream forgecode workspace deps; resolution depends on upstream tailcallhq/forgecode bumps. - Pre-existing fork-specific RUSTSEC-2026-* ignores preserved. - cargo deny check advisories: PASS.
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 58 minutes and 52 seconds.Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the deny.toml configuration to ignore several security advisories related to unmaintained transitive dependencies introduced via upstream workspace dependencies. The feedback suggests correcting the rationale for the rustls-pemfile advisory to accurately reflect its versioning and recommends removing historical notes from the configuration file to keep it focused on the current state.
| # per RustSec; resolution depends on upstream tailcallhq/forgecode bumps. | ||
| { id = "RUSTSEC-2025-0141", reason = "bincode 1.x unmaintained; transitive via upstream workspace deps; bincode 2.x migration is upstream-owned." }, | ||
| { id = "RUSTSEC-2024-0436", reason = "paste unmaintained; transitive via proc-macro deps; paste! macro not invoked directly in Phenotype additions." }, | ||
| { id = "RUSTSEC-2025-0134", reason = "rustls-pemfile unmaintained (folded into rustls-pki-types); transitive via upstream rustls stack; pending upstream bump." }, |
There was a problem hiding this comment.
The rationale for RUSTSEC-2025-0134 states that rustls-pemfile was folded into rustls-pki-types. In fact, rustls-pemfile 2.x is the maintained successor that utilizes rustls-pki-types. Updating the rationale to reflect that it is the 1.x version being superseded by 2.x provides clearer guidance for future maintenance when the upstream dependency eventually updates.
| { id = "RUSTSEC-2025-0134", reason = "rustls-pemfile unmaintained (folded into rustls-pki-types); transitive via upstream rustls stack; pending upstream bump." }, | |
| { id = "RUSTSEC-2025-0134", reason = "rustls-pemfile 1.x unmaintained (superseded by 2.x); transitive via upstream rustls stack; pending upstream bump." }, |
| { id = "RUSTSEC-2024-0436", reason = "paste unmaintained; transitive via proc-macro deps; paste! macro not invoked directly in Phenotype additions." }, | ||
| { id = "RUSTSEC-2025-0134", reason = "rustls-pemfile unmaintained (folded into rustls-pki-types); transitive via upstream rustls stack; pending upstream bump." }, | ||
| { id = "RUSTSEC-2024-0320", reason = "yaml-rust unmaintained; transitive via syntect (forge_display); upstream syntect has not migrated to yaml-rust2." }, | ||
| # Note: RUSTSEC-2026-0049 (advisory-not-detected) entry already removed in 40114d8dc. |
There was a problem hiding this comment.
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
|
CodeAnt AI finished reviewing your PR. |
| { id = "RUSTSEC-2024-0436", reason = "paste unmaintained; transitive via proc-macro deps; paste! macro not invoked directly in Phenotype additions." }, | ||
| { id = "RUSTSEC-2025-0134", reason = "rustls-pemfile unmaintained (folded into rustls-pki-types); transitive via upstream rustls stack; pending upstream bump." }, | ||
| { id = "RUSTSEC-2024-0320", reason = "yaml-rust unmaintained; transitive via syntect (forge_display); upstream syntect has not migrated to yaml-rust2." }, | ||
| # Note: RUSTSEC-2026-0049 (advisory-not-detected) entry already removed in 40114d8dc. |
There was a problem hiding this comment.
SUGGESTION: Remove historical note about RUSTSEC-2026-0049; policy files should maintain current state only, not historical tracking of removed entries.
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (1 file)
Reviewed by ling-2.6-1t-20260423:free · 5,372,718 tokens |
User description
Adds 4 ignore entries for bincode 1.x, paste, rustls-pemfile, yaml-rust — all transitive via upstream forgecode workspace deps. Fork-specific RUSTSEC-2026-* ignores preserved. cargo deny check advisories now PASSes.
Note
Low Risk
Low risk config-only change that only affects
cargo denyadvisory reporting; it may mask future transitive dependency issues until upstream dependencies are updated.Overview
Updates
deny.tomlto keep the existing fork-specificRUSTSEC-2026-*ignores and add four new ignored RustSec advisories for unmaintained transitive crates (bincode1.x,paste,rustls-pemfile,yaml-rust), each with an explicit rationale tied to upstream workspace dependencies.This makes the
cargo denyadvisory check pass without changing any runtime code or dependencies.Reviewed by Cursor Bugbot for commit 9c1ef52. Bugbot is set up for automated code reviews on this repo. Configure here.
CodeAnt-AI Description
Keep
cargo denypassing by ignoring known transitive advisories with reasonsWhat Changed
Impact
✅ Fewer cargo deny failures✅ Clearer advisory reporting✅ No change to runtime behavior🔄 Retrigger CodeAnt AI Review
Details
💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.