Skip to content

fix error: global flags not at the start of the expression at position 1 - #426

Merged
Kronuz merged 1 commit into
Kronuz:masterfrom
omit66:master
Apr 14, 2023
Merged

fix error: global flags not at the start of the expression at position 1#426
Kronuz merged 1 commit into
Kronuz:masterfrom
omit66:master

Conversation

@omit66

@omit66 omit66 commented Nov 3, 2022

Copy link
Copy Markdown

PyScss stopped working for python311.

From https://docs.python.org/3.11/whatsnew/3.11.html :

In re Regular Expression Syntax, global inline flags (e.g. (?i)) can now only be used at the start of regular expressions. Using them elsewhere has been deprecated since Python 3.6. (Contributed by Serhiy Storchaka in bpo-47066.)

The issue occurs in one pattern of the class scss.grammar.expression.SassExpressionScanner.

@lswainemoore

Copy link
Copy Markdown

just ran into this myself--thanks for putting together a solution. wonder what the process for getting this merged is.

@tgherzog

tgherzog commented Jan 1, 2023

Copy link
Copy Markdown

+1 on the fix - works great. Hope for a merge and update soon!

@glyph

glyph commented Feb 14, 2023

Copy link
Copy Markdown

Just hit this as well. Is there anything to be done to expedite this merge?

@tgherzog

tgherzog commented Feb 14, 2023

Copy link
Copy Markdown

His profile says that eOne is based in Kharkiv, so I imagine merges might not be the highest priority for him at the moment. @Kronuz is there anyone else that can respond to a pull request?

@carlosvega

Copy link
Copy Markdown

Yes, it would be great to merge this and release a new version

@jondricek

Copy link
Copy Markdown

@Kronuz and/or @e0ne do you have any plans to merge this into master and release a new version of pyScss?

@Kronuz
Kronuz merged commit 73559d0 into Kronuz:master Apr 14, 2023
@Kronuz

Kronuz commented Apr 14, 2023

Copy link
Copy Markdown
Owner

Sorry, I don't have too much time to work on pyScss laterly. Merged the pull request, but I wish there was a way to have continuous releases from GitHub, does anyone know if that's possible to set up, somehow?

@omit66

omit66 commented Apr 16, 2023

Copy link
Copy Markdown
Author

@Kronuz Maybe you could use GitHub actions to build and published your new releases? Have a Look at gh-action-pypi-publish.

@shwoodard

Copy link
Copy Markdown

@Kronuz please, pretty please release v1.4.1.

@jondricek

Copy link
Copy Markdown

Here is a repository I manage that automatically publishes to PyPI from the repo whenever a tag is pushed. It also runs flake8 to lint on every push, regardless if it is tagged. It uses gh-action-pypi-publish like @omit66 suggests. I'd be happy to make a pull request with something like this, but it would still require @Kronuz to setup his PyPI account's PYPI_API_TOKEN as a variable in the repository settings before it would actually work.

https://github.com/mitre-attack/mitreattack-python/blob/master/.github/workflows/lint-publish.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants