GitHub Issue #159: Require all assay transform scripts to reside in container's @scripts dir - #1048
Merged
Conversation
labkey-tchad
approved these changes
Aug 3, 2026
labkey-tchad
left a comment
labkey-tchad
left a comment
Member
There was a problem hiding this comment.
Is there any reason to not upload this file during LuminexTest.doInit so that all of the subclass tests get it automatically?
Contributor
Author
Yeah, that works too. In that case the utility file will always be uploaded to |
Contributor
Author
|
Note: I'm going to get this merged to develop but will plan to backport it to release26.8-SNAPSHOT shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/159
See related PR for rationale. This PR fixes the Luminex tests so that they include their utility file in the
@scriptsdir when using the assay transform scripts.Related Pull Requests
Changes
@scriptsdir