Item 10223: App GridPanel update to display filter/search pills in grid message area (experimental feature) - #795
Merged
Merged
Conversation
- and put the filter button and search box behind isGridColSortFilterEnabled()
…nfo section (previously displayed in the OmniBox input)
# Conflicts: # packages/components/package.json
…lue in the SearchBox - use replace instead of add when new search values are applied
# Conflicts: # packages/components/package.json # packages/components/releaseNotes/components.md
cnathe
changed the title
labkey-susanh
approved these changes
Apr 6, 2022
| actionValues: newActionValues, | ||
| }); | ||
|
|
||
| const newActionValues = removeActionValue(actionValues, actionValueIndex); |
Contributor
There was a problem hiding this comment.
This variable is not really needed, but no big deal.
…filters shouldn't disappear on apply without changes
…e view action to the start)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR is the next story in the App Grid panel UX filtering updates. This set of changes adds the search input to the grid button bar and displays the filter/search pills in the grid info/messaging area. It allows for those pills to be removed and the filter pills to be clicked to reopen the filter modal. This PR also removes the OmniBox from the grid display. Note that all changes are still behind an experimental feature flag at this point.
Related Pull Requests
Changes