Add null checks to consumers of QueryForm.getQueryDef - #159
Closed
labkey-tchad wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Also fixes a crawler error I found this morning: |
Contributor
|
I have a competing approach here, which makes getQueryDef() throw NotFoundException. I think that will be safe and eliminate a lot of null checks. https://github.com/LabKey/platform/tree/fb_containerFilterSelectRows I've kicked off the BVTs and DailyA to assess the change. @labkey-tchad feel free to queue more tests if there are any you think should be especially diagnostic |
cnathe
added a commit
that referenced
this pull request
Jul 31, 2026
…ontainer's @scripts dir (#7895) ## Rationale LabKey/internal-issues#159 Assay transform scripts configured through the designer must now live in the design's own container `@scripts` directory (writable only by platform developers), enforced by a new validateScriptLocation() in the save path, with a site-wide deprecated feature flag as an escape hatch and a usage metric approximating how many existing designs are non-compliant. The Selenium page object switches the default addTransformScript(File) to file-upload mode, deleting any same-named leftover from `@scripts` first. ## Related Pull Requests - #7895 - LabKey/testAutomation#3133 - LabKey/limsModules#2369 ## Changes - Add validateScriptLocation() call to make sure that assay transform script path is a child of the container's @scripts dir - Add optional feature flag to "turn off" the @scripts dir path validation check - Metric for approximate count of assay transform script paths that are not in an @scripts dir path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoping to prevent crawler errors before they happen