Skip to content

Fix issue with standalone maps not always spanning the entire visible viewport - #93

Merged
Malvoz merged 1 commit into
Maps4HTML:mainfrom
Malvoz:span-visible-viewport-fix
Feb 7, 2022
Merged

Fix issue with standalone maps not always spanning the entire visible viewport#93
Malvoz merged 1 commit into
Maps4HTML:mainfrom
Malvoz:span-visible-viewport-fix

Conversation

@Malvoz

@Malvoz Malvoz commented Feb 7, 2022

Copy link
Copy Markdown
Member

This is an attempt to prevent the gap below the map after exiting fullscreen:

by setting position: fixed, ref: https://developers.google.com/web/updates/2016/12/url-bar-resizing.

@Malvoz
Malvoz merged commit 5db0026 into Maps4HTML:main Feb 7, 2022
@Malvoz

Malvoz commented Feb 7, 2022

Copy link
Copy Markdown
Member Author

Seems to have worked. There are other ways to ensure URL Bar Resizing does not result in parts of maps being covered by the browser's chrome, or the map not spanning the entire visible viewport (e.g. using height: 100vh, though that's got its own set of problems: https://github.com/postcss/postcss-100vh-fix#postcss-100vh-fix).

This may be useful information for Maps4HTML/web-map-doc#26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant