fix: unset CI in ray.sub and virtual_cluster to prevent vLLM aliasing errors#3293
Draft
kajalj22 wants to merge 1 commit into
Draft
fix: unset CI in ray.sub and virtual_cluster to prevent vLLM aliasing errors#3293kajalj22 wants to merge 1 commit into
kajalj22 wants to merge 1 commit into
Conversation
PyTorch sets error_on_custom_op_aliasing=True when CI=true (see torch/_functorch/config.py:99), causing RuntimeError in vLLM custom ops such as sequence_parallel_chunk_impl. The CI env var propagates to Ray workers through the Ray daemon environment, so unsetting it in test scripts or per-recipe yaml (vllm_cfg.env_vars) is insufficient for general use. Fix at two levels: - ray.sub: unset CI in both head_cmd and worker_cmd before ray start, so all Ray daemons and the workers they spawn never see CI=true - virtual_cluster.py: strip CI from the runtime_env env_vars passed to ray.init + emit UserWarning so non-ray.sub launchers also get the fix with visibility Signed-off-by: Kajal Jain <kajalj@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code