Hi TN date class accuracy improvement - #418
Conversation
Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
79f8c53 to
017a615
Compare
for more information, see https://pre-commit.ci
…ion of more test cases Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
for more information, see https://pre-commit.ci
…mm-yyyy, dd-m-yyyy and mm-yyyy Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
for more information, see https://pre-commit.ci
|
|
||
| # Create union of suffixes and prefixes | ||
| suffix_union = pynini.union(*suffixes_list) | ||
| prefix_union = pynini.union(*prefixes_list) |
There was a problem hiding this comment.
can l36 through here be replaced by string file?
There was a problem hiding this comment.
Thanks for the suggestion! I explored pynini.string_file() for both. It works for suffix_union if we add identity columns to suffixes.tsv, since suffix comes after graph_year and doesn't affect year graph path selection. However, for prefix_union, even with identity columns, string_file() caused graph_year_thousands to incorrectly win over graph_year_hundreds_as_thousands for years like 1999, 1920, 1971, because prefix_union comes before graph_year in the concatenation, and the identity transducer from string_file() alters the weight landscape at that point.
I considered adjusting weights to compensate, but since graph_year_thousands and graph_year_hundreds_as_thousands are designed to be mutually exclusive, it was unclear why string_file() was breaking that exclusivity, making weight tuning risky. To keep both consistent and avoid that risk, I've now used pynini.string_map() for both, as it eliminates the intermediate list variables and the verbose open() + pynini.union() block while correctly handling single-column entries and preserving the expected FST behavior.
Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
for more information, see https://pre-commit.ci
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
* Hi TN: fraction class improvements with lexical mappings for special cases (#420) * Fix: fraction class improvements with lexical mappings Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * move common fraction mappings to TSV and add ASCII digit support Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * Jenkins date conflict resolved Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Hi TN date class accuracy improvement (#418) * date class accuracy improvement Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * Jenkins file date update for Hi TN Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Address Reviewer feedback regarding date tagger, tsv files and inclusion of more test cases Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * hi-tn-date: minor formatting fix Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * date tagger modification according to feedback removed support for d-mm-yyyy, dd-m-yyyy and mm-yyyy Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * replace open()+union() with string_map for suffix and prefix unions Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Hi TN money class bug fix (#424) * Hi TN money class bug fix Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added test cases with decimal portion having more than two digits for Indian Currency Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> --------- Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Hi TN Electronic: Fix partial TSV matching, chemical formula logic, and relative file paths (#425) * Fix partial TSV matching, added support for chemical formulas, and relative file paths Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Refactor electronic class with dynamic symbol matrix and chemical rules. Replaced hardcoded TSVs and Python symbol rules with a data-driven symbol_classes.tsv and dynamic elements.tsv. Fixed greedy over-tagging of standard English words and added Unicode support for complex chemical ions without breaking URL hyphen logic. Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Remove single capital letter units from Measure class (#429) Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * Hi TN: Implement Serial tagger (#440) * Hi TN Serial: Implement SerialFst tagger for Devanagari-numeric mixtures, number chains, and mathematical powers Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Address feedback for Hindi Serial Tagger PR Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Hi TN: Implement Roman semiotic class (#442) * Hi TN Roman class implementation Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * Refactor Roman FST to utilize shared serial Devanagari chars Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * Add __init__.py for serial and roman data folders Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update roman_graph weight to 1.07 and other minor changes Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * Feedback changes Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * reducing uncommon entries in electronic class tsv data files (#458) Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * Hi TN: Address, Electronic, Serial, and Cardinal FST Optimization and Bug Fix (#461) * Hi TN Address, Electronic, Serial, and Cardinal FST Optimizations and Bug Fixes Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * review feedback changes Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feedback review changes for address and electronic Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Hi tn v3: staging to main error fixed (#466) Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> --------- Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com> Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com> Co-authored-by: Shreyas Pawar <shrpawar@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
What does this PR do ?
Improved Date class accuracy from ~87 % to ~99 % by introducing additional graph coverage for the cases failing earlier.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.