Remove _SynchronousMemoryResource from cuda.core._memory public API#1933
Merged
Conversation
Remove _SynchronousMemoryResource from __all__ in _legacy.py since it is a private symbol (underscore-prefixed) that should not be part of the public API surface. Update internal imports in _device.pyx and test_launcher.py to use the full private module path (cuda.core._memory._legacy) instead of the package-level import.
mdboom
added
bug
|
mdboom
added
enhancement
cpcloud
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
_SynchronousMemoryResourceis a private symbol (underscore-prefixed) that was listed in__all__incuda/core/_memory/_legacy.py, making it unintentionally part of the public API surface ofcuda.core._memory.Fix:
_SynchronousMemoryResourcefrom__all__in_legacy.py_device.pyxandtest_launcher.pyto use the full private module path (cuda.core._memory._legacy) instead of the package-level importAll existing tests pass (242 passed, 11 skipped across test_memory.py and test_launcher.py).