Skip to content

Fix #2377: Reorganize the test helpers (where appropriate) to cuda_python_test_helpers#2384

Open
mdboom wants to merge 5 commits into
NVIDIA:mainfrom
mdboom:test-helpers
Open

Fix #2377: Reorganize the test helpers (where appropriate) to cuda_python_test_helpers#2384
mdboom wants to merge 5 commits into
NVIDIA:mainfrom
mdboom:test-helpers

Conversation

@mdboom

@mdboom mdboom commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

This moves test helpers that are generically useful across the subprojects to cuda_python_test_helpers. It fixes some corner cases in the sys.path hack to import cuda_python_test_helpers. It doesn't install it as a proper package -- I had hoped that would be possible, but upstream pip does not support path dependencies in a dependency group. Using that would require pip to be improved or require everyone to use uv.

@copy-pr-bot

copy-pr-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Jul 17, 2026
@mdboom

mdboom commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@mdboom

mdboom commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

Copy link
Copy Markdown

@mdboom

mdboom commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@mdboom

mdboom commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions github-actions Bot added the cuda.pathfinder Everything related to the cuda.pathfinder module label Jul 17, 2026
@mdboom mdboom added the test Improvements or additions to tests label Jul 20, 2026
@mdboom mdboom self-assigned this Jul 20, 2026
@mdboom
mdboom marked this pull request as ready for review July 20, 2026 13:12
@mdboom mdboom changed the title Experiment: Install test_helpers as a package Fix #2377: Reorganize the test helpers (where appropriate) to cuda_python_test_helpers Jul 20, 2026
@mdboom
mdboom requested a review from leofang July 20, 2026 13:17
@mdboom mdboom added the PR review get-together Mark PRs you'd like the team to review at the weekly PR review get-together. label Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module cuda.pathfinder Everything related to the cuda.pathfinder module PR review get-together Mark PRs you'd like the team to review at the weekly PR review get-together. test Improvements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants