Skip to content

Add CI status check#379

Merged
leofang merged 1 commit into
NVIDIA:mainfrom
leofang:status_check
Jan 12, 2025
Merged

Add CI status check#379
leofang merged 1 commit into
NVIDIA:mainfrom
leofang:status_check

Conversation

@leofang

@leofang leofang commented Jan 12, 2025

Copy link
Copy Markdown
Member

Close #377.

@leofang leofang self-assigned this Jan 12, 2025
@copy-pr-bot

copy-pr-bot Bot commented Jan 12, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofang leofang added P0 High priority - Must do! CI/CD CI/CD infrastructure labels Jan 12, 2025
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Jan 12, 2025
@leofang

leofang commented Jan 12, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@leofang
leofang marked this pull request as draft January 12, 2025 01:57
@copy-pr-bot

copy-pr-bot Bot commented Jan 12, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofang

leofang commented Jan 12, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@leofang
leofang marked this pull request as ready for review January 12, 2025 02:19
@leofang

leofang commented Jan 12, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Jan 12, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang

leofang commented Jan 12, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@leofang leofang added the to-be-backported Trigger the bot to raise a backport PR upon merge label Jan 12, 2025
@leofang

leofang commented Jan 12, 2025

Copy link
Copy Markdown
Member Author

Let me admin-merge this because this is only the 1st step; the 2nd step is to add the check status job name to the repo branch rule so that it's honored by GitHub UI. After confirming this works, I'll backport the PR.

@leofang
leofang merged commit ece3281 into NVIDIA:main Jan 12, 2025
@leofang
leofang deleted the status_check branch January 12, 2025 03:55
@leofang

leofang commented Jan 12, 2025

Copy link
Copy Markdown
Member Author

Let me admin-merge this because this is only the 1st step; the 2nd step is to add the check status job name to the repo branch rule so that it's honored by GitHub UI. After confirming this works, I'll backport the PR.

It works: #377 (comment). Let me backport...

@leofang

leofang commented Jan 12, 2025

Copy link
Copy Markdown
Member Author

I noticed that the backport CI is supposed to send an error message but it did not, because of an error:

Error: The template is not valid. .github/workflows/backport.yml (Line: 36, Col: 28): Input string '11.8.x' is not a valid number. Path '', line 1, position 6.

https://github.com/NVIDIA/cuda-python/actions/runs/12730243631/job/35482964722
I'll fix it.

This was referenced Jan 12, 2025
rparolin added a commit to rparolin/cuda-python that referenced this pull request Jul 21, 2026
It didn't actually guard the two lifetime fixes: the driver copies the path
during the set call (so the NVIDIA#379 latent UAF can't trigger), and a missing free
leaks silently (so NVIDIA#381 wouldn't fail the test either).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure P0 High priority - Must do! to-be-backported Trigger the bot to raise a backport PR upon merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Require all checks passing before merging

1 participant