fix referenced morphs/biophysics: load from included files, add tests, add some error checking - #197
Merged
Conversation
This is for use-cases where we do not want to modify the original document at all, for example, visualization.
sanjayankur31
marked this pull request as draft
August 9, 2024 16:56
Contributor
Author
|
Gotta test this out a little more to confirm it's doing the right things. |
sanjayankur31
marked this pull request as ready for review
August 12, 2024 14:04
Contributor
Author
|
@pgleeson this is ready now I think.
It overwrites the NeuroMLDocument object by default, but perhaps it shouldn't in case users then continue to use it and end up writing it to file or something without realising that we've changed their model here? |
sanjayankur31
changed the title
Member
|
Looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.