Skip to content

feat: remove numpy version fix - #207

Merged
sanjayankur31 merged 2 commits into
developmentfrom
feat-bump-numpy
Jun 9, 2025
Merged

feat: remove numpy version fix#207
sanjayankur31 merged 2 commits into
developmentfrom
feat-bump-numpy

Conversation

@sanjayankur31

Copy link
Copy Markdown
Contributor

@pgleeson

pgleeson commented Jun 9, 2025

Copy link
Copy Markdown
Member

Might be good to integrate this and test. libnml dep on numpy<2 is propagating to multiple other repos (e.g. mdf) and possibly breaking some of the tests with 3.13...

@sanjayankur31
sanjayankur31 merged commit 2a5b6cc into development Jun 9, 2025
@sanjayankur31
sanjayankur31 deleted the feat-bump-numpy branch June 9, 2025 13:04
@pgleeson

pgleeson commented Jun 9, 2025

Copy link
Copy Markdown
Member

@sanjayankur31

Copy link
Copy Markdown
Contributor Author

FYI still numpy <2.0 being used... https://github.com/NeuralEnsemble/libNeuroML/actions/runs/15535251138/job/43732649444

Yeh, looks like it's because of six, which was needed for py2/3 compatibility. We don't need it any more. Working on that in #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants