nixos/nextcloud: remove opcache.enable_cli=1 - #295932
Merged
Merged
Conversation
Upstream no longer recommends enabling the opcache cli. See the following: - nextcloud/documentation#1439 - nextcloud/server#15468
github-actions
Bot
added
6.topic: nixos
ofborg
Bot
added
10.rebuild-darwin: 0
e1mo
approved these changes
Mar 14, 2024
e1mo
left a comment
e1mo
left a comment
Member
There was a problem hiding this comment.
From skimming the linked PRs this seems sensible 👍
SuperSandro2000
approved these changes
Mar 14, 2024
Member
|
From what I see, this is a bugfix and stable users would benefit from that as well -> backporting. |
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Upstream no longer recommends enabling the opcache cli.
See the following:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.