[17.0][OU-ADD] mass_mailing: Migration to 17.0. - #4785
Conversation
|
Could you maintain the commit in #4671 and then add you a second commit with your improvements? |
Could you specify the relevant changes in this PR? I started from scratch because, from my point of view, these changes are incorrect. The author is dropping a SQL unique constraint on unique_contact_list, but this constraint is still present. So, if I preserve this change, I would need to revert it again in my commit. Additionally, most of the changes in the |
|
Ok, I was asking for to make it easier the review process. With your way, I will need to compare the two PRs 🤷♂️ |
Ok, sorry. I need to add "superseded" because the intention is to close the other PR without merging. |
|
/ocabot migration mass_mailing |
|
please rebase (and handle above comment) |
4580fcd to
a52ee38
Compare
| # NOTHING TO DO: new feature | ||
|
|
||
| mass_mailing / utm.campaign / ab_testing_completed (boolean): now a function | ||
| # NOTHING TO DO: now is compute with store=True |
There was a problem hiding this comment.
Initialize the column in pre and do a SQL for assigning the value on post after processing ab_testing_winner_mailing_id. If not, the ORM computation will take place before and this won't have a valid value.
There was a problem hiding this comment.
This field already exist in V16 https://github.com/odoo/odoo/blob/34947c01623a9fc753197bd55d6121d9c6fa682f/addons/mass_mailing/models/utm_campaign.py#L25, so recomputation is not triggered. Why is it necessary to initialize the column? Please clarify.
a52ee38 to
65e4f18
Compare
Supersedes #4671
TT49916
@Tecnativa @pedrobaeza @MiquelRForgeFlow could you please review this?