[IMP] report_substitute: add hook to render non-qweb-pdf substitutio reports - #1185
Merged
OCA-git-bot merged 1 commit intoJul 29, 2026
Conversation
… reports _render_qweb_pdf only substitutes when the resolved substitution report's report_type is qweb-pdf; otherwise it silently falls back to rendering the original report. Extract that decision into an overridable _render_qweb_pdf_substitution hook so modules introducing other report types can render their own substitution reports on this path.
Contributor
|
Hi @sbejaoui, |
Member
Author
|
Hey @sbejaoui @jjscarafia @HviorForgeFlow @augusto-weiss, kindly asking for a review :) |
sebinthomasst
approved these changes
Jul 28, 2026
jojicnikola
approved these changes
Jul 28, 2026
HviorForgeFlow
approved these changes
Jul 29, 2026
Member
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at cb3c9ae. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_render_qweb_pdf only substitutes when the resolved substitution report's report_type is qweb-pdf; otherwise it silently falls back to rendering the original report. Extract that decision into an overridable _render_qweb_pdf_substitution hook so modules introducing other report types can render their own substitution reports on this path.