Skip to content

[13.0][ADD] Boolean Button Ported from 12 to 13 - #1822

Merged
OCA-git-bot merged 1 commit into
OCA:13.0from
SkiBY:13.0
Feb 28, 2022
Merged

[13.0][ADD] Boolean Button Ported from 12 to 13#1822
OCA-git-bot merged 1 commit into
OCA:13.0from
SkiBY:13.0

Conversation

@SkiBY

@SkiBY SkiBY commented Feb 15, 2021

Copy link
Copy Markdown

No description provided.

@SkiBY
SkiBY marked this pull request as draft February 16, 2021 09:21
@SkiBY
SkiBY marked this pull request as ready for review February 16, 2021 09:22
@SkiBY SkiBY mentioned this pull request Feb 16, 2021
Closed
41 tasks
thomaspaulb
thomaspaulb requested changes Feb 26, 2021
View reviewed changes

@thomaspaulb thomaspaulb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SkiBY I'll go into the technical details once the license and guideline stuff has been tackled.

Comment thread web_boolean_button/__manifest__.py Outdated
Comment thread web_boolean_button/__manifest__.py Outdated
Comment thread web_boolean_button/__manifest__.py Outdated
Comment thread web_boolean_button/README.rst Outdated
Comment thread web_boolean_button/README.rst Outdated
Comment thread web_boolean_button/__manifest__.py
@SkiBY SkiBY changed the title Boolean Button Ported from 12 to 13 [ADD][13.0] Boolean Button Ported from 12 to 13 Mar 7, 2021
@SkiBY

SkiBY commented Mar 7, 2021

Copy link
Copy Markdown
Author

Changes after review added.

@SkiBY SkiBY changed the title [ADD][13.0] Boolean Button Ported from 12 to 13 [13.0][ADD] Boolean Button Ported from 12 to 13 Mar 8, 2021
thomaspaulb
thomaspaulb requested changes Mar 8, 2021
View reviewed changes
Comment thread web_boolean_button/static/tests/form_tests.js Outdated
@thomaspaulb

thomaspaulb commented Aug 13, 2021

Copy link
Copy Markdown

@hbrunn It seems something is up here with the Runbot, I can't access the logs. It also asks for approval of a maintainer. Do you know what is going on here?

@SkiBY

SkiBY commented Oct 14, 2021

Copy link
Copy Markdown
Author

@thomaspaulb looks like all green

@thomaspaulb thomaspaulb mentioned this pull request Feb 1, 2022
Merged
@OCA-git-bot

OCA-git-bot commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt

dreispt commented Feb 6, 2022

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Feb 6, 2022

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-1822-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 6, 2022
@OCA-git-bot
Merge PR #1822 into 13.0
f77e5db 
Signed-off-by dreispt
@OCA-git-bot

OCA-git-bot commented Feb 6, 2022

Copy link
Copy Markdown
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-1822-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@gurneyalex

gurneyalex commented Feb 28, 2022

Copy link
Copy Markdown
Member

CI on the merge is broken

  • pre commit failure on the website field of the manifest file

@SkiBY can you fix this?

@gurneyalex gurneyalex mentioned this pull request Feb 28, 2022
Open
@thomaspaulb

thomaspaulb commented Feb 28, 2022

Copy link
Copy Markdown

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Feb 28, 2022

Copy link
Copy Markdown
Contributor

Sorry @thomaspaulb you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@thomaspaulb

thomaspaulb commented Feb 28, 2022

Copy link
Copy Markdown

@gurneyalex I fixed that small thing, then squashed the commits. Should be ready for merge now.

@hbrunn

hbrunn commented Feb 28, 2022

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Feb 28, 2022

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-1822-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 1e494f5 into OCA:13.0 Feb 28, 2022
@OCA-git-bot

OCA-git-bot commented Feb 28, 2022

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 7d123b1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments
@thomaspaulb thomaspaulb thomaspaulb approved these changes
+1 more reviewer
@ntsirintanis ntsirintanis ntsirintanis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@SkiBY @thomaspaulb @OCA-git-bot @dreispt @gurneyalex @hbrunn @pedrobaeza @ntsirintanis