feat: add runbooks.Get for space-wide runbook queries - #433
Open
Scott-Emberson wants to merge 1 commit into
Open
feat: add runbooks.Get for space-wide runbook queries#433Scott-Emberson wants to merge 1 commit into
Scott-Emberson wants to merge 1 commit into
Conversation
The space-wide runbooks endpoint and its RunbooksQuery filter struct both already existed, but no function connected them, so callers could only reach runbooks through the project-scoped List. Add Get, following the same newclient.GetByQuery pattern used by tenants and the other resources sharing this template. This lets callers filter runbooks by project, name, or ID across a space, which the Terraform provider needs to offer a runbooks data source (OctopusDeploy/terraform-provider-octopusdeploy#209). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The space-wide runbooks endpoint and its
RunbooksQueryfilter struct both already exist in this package, but nothing connects them. Callers can only reach runbooks through the project-scopedList. This addsGet, using the samenewclient.GetByQuerypattern thattenants.Getand the other functions sharing this template already use.RunbooksQueryis not referenced anywhere in the SDK today. This makes it reachable.The Terraform provider needs space-wide runbook querying for a runbooks data source (OctopusDeploy/terraform-provider-octopusdeploy#209). Without it the data source would be limited to project-scoped listing, which is not what that issue asks for.
Tests cover expansion of
RunbooksQueryinto the template for every filter, and the empty-query case.