Conversation
It will be now separate from Explorer's icons in taskbar. Open-Shell icon will be displayed for better clarity. #31 (comment)
Menu offsets were previously applied to s_MainMenuLimits. Though when deciding where to put start menu (CalculateCorner) we are now taking into account also position of start button (as since Win11 it may not be in corner of the screen). This broke negative menu offsets. We will fix it by applying menu offsets in CalculateCorner as a last step once we have determined start menu position. This should make even more sense than previous approach.
Member
Author
|
@AEAEAEAE4343 Could you eventually check if such change still works for you? |
This was referenced Jul 31, 2023
|
The PR looks good as far as I can tell. As long as the option behaves as expected, I’m fine with the changes. |
Member
Author
|
@AEAEAEAE4343
Well, that's what I wanted you to confirm :) |
Changes in be8568 commit caused that under certain circumstances search results may overlap "Search the Internet" item.
Commit be8568c that introduced option to disable "See more results" also changed behavior of "Searching..." item that indicates search in progress. We will now make sure that the search progress indicator is displayed always. No matter of options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.