Bump optimagic, boilerplate - #96
Merged
Merged
Conversation
Boilerplate: bumps .ai-instructions to latest main and adds pandas.md/plotting.md to the included modules; migrates project instructions to AGENTS.md with CLAUDE.md/GEMINI.md as thin wrappers; adds the missing check-github-workflows hook; stops nbstripout from removing notebook kernelspec (needed since this project uses Jupyter Book 2/mystmd); adds a mystmd-flavoured mdformat hook for docs/; and bumps pixi-version/actions/setup-python in CI to current releases. Fallout from the optimagic/ruff/ty version bumps already on this branch: optimagic's fun_and_jac signature changed (test_cf_recovery.py); newer ty flags a stale ignore comment (_beartype_conf.py), a widened scan loop_args type (likelihood_debug.py), and Series-vs-floating arithmetic (test_correlation_heatmap.py); newer ruff flags implicit string concatenation (identification.py) and enables CPY001/PLR0917, both ignored in pyproject.toml (no per-file copyright convention exists; PLR0913 -- too many arguments -- was already ignored, so PLR0917 -- too many positional arguments -- joins it for consistency).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 95.82% 95.83%
=======================================
Files 142 142
Lines 14122 14126 +4
=======================================
+ Hits 13533 13537 +4
Misses 589 589 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optimagicto a released version (>=0.5.4, dropping the git-branch pin) and bumpruff/typre-commit revs; fix the resultingty/ruff-checkfallout (optimagic.minimize'sfun_and_jacsignature, a stalety: ignore, a widenedscanloop-arg type,Series-vs-floatingarithmetic, implicit string concatenation, and newly-enabledCPY001/PLR0917rules — both added toextend-ignoresince no per-file copyright convention exists andPLR0913was already ignored for the same reason)..ai-instructionsboilerplate update: bump the submodule, addpandas.md/plotting.mdmodules, migrate project instructions intoAGENTS.md(withCLAUDE.md/GEMINI.mdas thin wrappers), add the missingcheck-github-workflowshook, stopnbstripoutfrom removing notebookkernelspec(needed for Jupyter Book 2/mystmd), add amdformat-mysthook fordocs/, and bumppixi-version/actions/setup-pythonin CI to current releases.Test plan
prek run --all-filespasses cleanlypixi run -e tests-cpu tests: 794 passed, 3 deselectedpixi run -e tests-cpu pytest tests/test_identification.py: 18 passed🤖 Generated with Claude Code