Skip to content

📝 CodeRabbit Chat: Make BulkEditTable aria labels generic - #281

Closed
coderabbitai[bot] wants to merge 11 commits into
feature/grid-filter-continuedfrom
coderabbitai/chat/bf4db8a
Closed

📝 CodeRabbit Chat: Make BulkEditTable aria labels generic#281
coderabbitai[bot] wants to merge 11 commits into
feature/grid-filter-continuedfrom
coderabbitai/chat/bf4db8a

Conversation

@coderabbitai

@coderabbitai coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Code changes was requested by @smarcet.

The following files were modified:

  • src/components/mui/BulkEditTable/BulkEditTable.js
  • src/components/mui/BulkEditTable/components/Row.js

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Author

Important

Review skipped

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 530e1070-5aea-4e31-a599-42d46461d92a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the BulkEditTable row action button accessibility labels generic by introducing an entityName prop that replaces the hard-coded "event" wording, allowing the same component to be reused across different entity types without misleading screen reader output.

Changes:

  • Added an entityName prop to BulkEditTable and propagated it down to row rendering.
  • Updated row action aria-labels for Edit/Delete to use entityName instead of "event".
  • Updated PropTypes/defaultProps in both components to include entityName (defaulting to "row").

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/components/mui/BulkEditTable/BulkEditTable.js Adds entityName prop (with default) and passes it to Row so the table can generate generic action labels.
src/components/mui/BulkEditTable/components/Row.js Uses entityName in Edit/Delete button aria-labels and defines corresponding prop types/default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@santipalenque
santipalenque force-pushed the feature/grid-filter-continued branch 2 times, most recently from 061c7d8 to 7baf9d4 Compare July 8, 2026 18:22
@smarcet smarcet closed this Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants