📝 CodeRabbit Chat: Make BulkEditTable aria labels generic - #281
📝 CodeRabbit Chat: Make BulkEditTable aria labels generic#281coderabbitai[bot] wants to merge 11 commits into
Conversation
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Pull request overview
This PR makes the BulkEditTable row action button accessibility labels generic by introducing an entityName prop that replaces the hard-coded "event" wording, allowing the same component to be reused across different entity types without misleading screen reader output.
Changes:
- Added an
entityNameprop toBulkEditTableand propagated it down to row rendering. - Updated row action
aria-labels for Edit/Delete to useentityNameinstead of"event". - Updated
PropTypes/defaultPropsin both components to includeentityName(defaulting to"row").
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/mui/BulkEditTable/BulkEditTable.js | Adds entityName prop (with default) and passes it to Row so the table can generate generic action labels. |
| src/components/mui/BulkEditTable/components/Row.js | Uses entityName in Edit/Delete button aria-labels and defines corresponding prop types/default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
061c7d8 to
7baf9d4
Compare
Code changes was requested by @smarcet.
The following files were modified:
src/components/mui/BulkEditTable/BulkEditTable.jssrc/components/mui/BulkEditTable/components/Row.js