Updated user Profile - #2
Merged
Merged
Conversation
Added public_profile_allow_chat_with_me Updated token introspection response Signed-off-by: smarcet@gmail.com <smarcet@gmail.com> Change-Id: Ib22b674605e469f52d582b5e6e62a0b42c00c6ae
smarcet
added a commit
that referenced
this pull request
Sep 30, 2021
Added public_profile_allow_chat_with_me Updated token introspection response Signed-off-by: smarcet@gmail.com <smarcet@gmail.com> Change-Id: Ib22b674605e469f52d582b5e6e62a0b42c00c6ae
smarcet
added a commit
that referenced
this pull request
Jul 23, 2026
Both cancel paths (resetToPasswordFlow and handleDelete) reset the UI optimistically and fired cancelLogin() without handling failure beyond a console.error - on a network failure the server-side pending challenge silently survived until its 300s TTL while the UI told the user it was cancelled. Extract the duplicated call into a single cancelPendingLogin() helper that warns the user via the existing snackbar when the server-side invalidation fails, so they know the pending verification will only die by its own TTL. The optimistic reset is kept - the user asked to cancel, so returning control immediately stays correct. PR #142 review finding LOW #2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added public_profile_allow_chat_with_me
Updated token introspection response
Signed-off-by: smarcet@gmail.com smarcet@gmail.com
Change-Id: Ib22b674605e469f52d582b5e6e62a0b42c00c6ae