Skip to content

added redis properties - #121

Merged
drtechie merged 1 commit into
PSMRI:mainfrom
ramnar:main
Feb 25, 2026
Merged

added redis properties#121
drtechie merged 1 commit into
PSMRI:mainfrom
ramnar:main

Conversation

@ramnar

@ramnar ramnar commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

📋 Description

JIRA ID:

Please provide a summary of the change and the motivation behind it. Include relevant context and details.


✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)
  • New feature (non-breaking change which adds functionality)
  • 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🛠 Refactor (change that is neither a fix nor a new feature)
  • ⚙️ Config change (configuration file or build script updates)
  • 📚 Documentation (updates to docs or readme)
  • 🧪 Tests (adding new or updating existing tests)
  • 🎨 UI/UX (changes that affect the user interface)
  • 🚀 Performance (improves performance)
  • 🧹 Chore (miscellaneous changes that don't modify src or test files)

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

Summary by CodeRabbit

  • Chores
    • Updated environment configuration to add Redis connection settings.

@coderabbitai

coderabbitai Bot commented Feb 25, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The pull request adds two new Redis configuration properties (host and port) to the example environment properties file and adjusts newline formatting to ensure proper file structure.

Changes

Cohort / File(s) Summary
Redis Configuration
src/main/environment/ecd_example.properties
Added spring.redis.host=localhost and spring.redis.port=6379 properties; adjusted trailing newline formatting.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Redis hops into the config file so bright,
With localhost and port six-three-seven-nine in sight!
A newline here, a property there,
The rabbit's work is simple and fair! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'added redis properties' directly and accurately describes the main change: adding two new Redis configuration properties (spring.redis.host and spring.redis.port) to the environment file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/main/environment/ecd_example.properties (1)

30-31: Consider externalizing Redis host/port via env placeholders.

Lines 30–31 are valid, but using placeholders reduces environment-specific file edits and deployment drift.

♻️ Suggested tweak
-spring.redis.host=localhost
-spring.redis.port=6379
+spring.redis.host=${REDIS_HOST:localhost}
+spring.redis.port=${REDIS_PORT:6379}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/main/environment/ecd_example.properties` around lines 30 - 31, Replace
the hardcoded Redis values with environment-placeholder expressions so
deployments can override them without editing the file; update the
spring.redis.host and spring.redis.port entries to use Spring property
placeholders that read from environment variables (e.g., ${REDIS_HOST:localhost}
and ${REDIS_PORT:6379}), and ensure documentation or README mentions the
REDIS_HOST and REDIS_PORT env var names expected by the application.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/main/environment/ecd_example.properties`:
- Around line 30-31: Replace the hardcoded Redis values with
environment-placeholder expressions so deployments can override them without
editing the file; update the spring.redis.host and spring.redis.port entries to
use Spring property placeholders that read from environment variables (e.g.,
${REDIS_HOST:localhost} and ${REDIS_PORT:6379}), and ensure documentation or
README mentions the REDIS_HOST and REDIS_PORT env var names expected by the
application.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ba9e4a and 60054d4.

📒 Files selected for processing (1)
  • src/main/environment/ecd_example.properties

@drtechie
drtechie merged commit 28b50ee into PSMRI:main Feb 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants