Skip to content

fix(oracle): match .slnx solutions + deepen shallow clone so Infer# can build#23

Merged
PhysShell merged 1 commit into
mainfrom
claude/zen-pasteur-76hfs1
Jun 17, 2026
Merged

fix(oracle): match .slnx solutions + deepen shallow clone so Infer# can build#23
PhysShell merged 1 commit into
mainfrom
claude/zen-pasteur-76hfs1

Conversation

@PhysShell

@PhysShell PhysShell commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Two build-blockers the first real Dapper run exposed

The first dispatch of oracle (cross-tool) on DapperLib/Dapper (run 27660966107) got CodeQL + own-check running, but the Infer# build failed, so the comparison stayed CodeQL-only. Two distinct causes, both fixed:

1. Dapper's solution is Dapper.slnx, not .sln

Dapper moved to the newer XML solution format (Dapper.slnx). The auto-detect's find -name '*.sln' didn't match it → note: 0 root / 0 total → dir fallback → MSB1050 (root has multiple projects).

→ Auto-detect now matches both *.sln and *.slnx.

2. Shallow clone breaks Nerdbank.GitVersioning

Even with the solution named explicitly (build: Dapper.slnx), the build died in nbgv:

error MSB4018: Nerdbank.GitVersioning.GitException: Shallow clone lacks the objects
required to calculate version height. ... commit ... could not be found.

We clone the target --depth 1, but nbgv (which Dapper uses to compute its version at build time) walks git history.

→ Before building, deepen the clone: git -C target fetch --unshallow --tags (guarded with || true — harmless when already complete). CodeQL + own-check are unaffected (they read source, no build).

Docs

docs/notes/oracle.md updated: .slnx is recognised, and the shallow clone is deepened for version tools like nbgv.

Honest note

Building arbitrary third-party repos for Infer# is inherently fragile (SDK pins, restore, custom targets); that's why the build step is continue-on-error with a partial report. These two fixes clear the specific blockers Dapper hit — a common stack (.slnx + nbgv), so they should generalise.

Verified

oracle.yml valid YAML · build-step bash parses · .slnx root-match check passes · no comparator change (--selftest still 12/12).

After merge

Re-dispatch oracle (cross-tool), repo = DapperLib/Dapper, no build inputDapper.slnx is auto-picked and the deepened clone lets nbgv compute the version.

🤖 Generated with Claude Code


Generated by Claude Code

Summary by CodeRabbit

Release Notes

  • Chores

    • Improved build workflow's solution file selection logic to prefer root-level solutions.
    • Enhanced git history handling during the build process to support version computation tools.
  • Documentation

    • Updated documentation to clarify solution selection behavior and git history handling in the build process.

The first real oracle dispatch on Dapper (run 27660966107 / 27661...) failed to
build for Infer# for two reasons, both fixed here:

1. Dapper's solution is `Dapper.slnx` (the newer XML solution format), which the
   autodetect `find -name '*.sln'` did not match -> "0 root / 0 total" -> dir
   fallback -> MSB1050. Now match both `*.sln` and `*.slnx`.
2. Even with the solution named explicitly, the build failed in
   Nerdbank.GitVersioning ("Shallow clone lacks the objects required to calculate
   version height"): the target is cloned `--depth 1`, but nbgv walks git history
   to compute the version. Deepen with `git fetch --unshallow --tags` before
   building (guarded with `|| true`; harmless when already complete).

CodeQL + own-check are unaffected (they read source, no build). docs/notes/oracle.md
updated. oracle.yml valid YAML; build-step bash parses; `.slnx` root-match verified.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rg8kSk1YT14x7A1vo5zgED
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 942baf6d-06e1-401c-b490-ee3ab24b7bce

📥 Commits

Reviewing files that changed from the base of the PR and between da2c4b0 and 4d35e16.

📒 Files selected for processing (2)
  • .github/workflows/oracle.yml
  • docs/notes/oracle.md

📝 Walkthrough

Walkthrough

The oracle workflow's Infer# build-target logic is updated to match both .sln and .slnx files and to prefer a unique root-level solution before scanning the target directory. A failure-tolerant git fetch --unshallow --tags step is added before building. Documentation is updated to reflect these changes.

Changes

Infer# Build Target Selection and Shallow Clone Deepening

Layer / File(s) Summary
Infer# solution selection and unshallow fetch
.github/workflows/oracle.yml, docs/notes/oracle.md
Solution file matching is broadened to include .slnx, root-level unique solution is preferred before falling back to a directory scan, the ambiguity note message is revised, and a quiet failure-tolerant git fetch --unshallow --tags step is added before building. Documentation is updated to describe the new selection priority and the shallow clone deepening step.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • PhysShell/Own.NET#22: Directly related — also modifies .github/workflows/oracle.yml to improve Infer# build-target auto-selection with root-level .sln/.slnx preference and target fallback.

Poem

🐇 A .slnx was lost in the tree,
But the rabbit sniffed root — "Ah-ha, that is thee!"
Unshallow the clone, let the tags flow free,
For versioning tools need their full history.
Hop hop, the build runs as neat as can be! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: extending solution format matching to .slnx files and deepening the shallow clone to support build-time version tools like Nerdbank.GitVersioning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/zen-pasteur-76hfs1

Comment @coderabbitai help to get the list of available commands and usage tips.

@PhysShell
PhysShell merged commit 32ad714 into main Jun 17, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants