🔥 feat(api)!: delete messaging.mkurator.dev/v1alpha1 Go types + conversion webhook (8e-8b) - #176
Merged
Merged
Conversation
…nectionDependents (8e-8b)
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…deepcopy; tidy stale config comments (8e-8b)
konih
marked this pull request as ready for review
July 30, 2026 19:53
The fuzz job matrix ran FuzzQueue/Topic/Channel/ChannelAuthRule/AuthorityRecord/ QueueManagerConnection ConversionRoundTrip against ./api/v1alpha1/ — both the fuzz targets and that directory were deleted with v1alpha1 in this lane. No fuzz tests remain (all were conversion round-trips), so the job is removed entirely.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8e-8b — delete the v1alpha1 Go code entirely
Follows 8e-8a (v1alpha1 no longer served). This lane removes the v1alpha1 Go API version outright.
Deleted
api/v1alpha1/(entire package): all types,conversion*.go(incl.conversion_auth.goand the ADR-0027-rejectedauthenticationUnionSnapshotAnnotationhack from fix(api): preserve authentication union across v1alpha1 spoke round trip (AUTH-14) #168),conversion_fuzz_test.go,zz_generated.deepcopy.go,groupversion_info.go, all*_test.go.internal/webhook/v1alpha1/(entire package).internal/webhook/conversion/(entire package).Repointed / pruned (tree compiles + passes on v1beta1 only)
adoption_policy.go,lifecycle_policy.go,suspend.go): removed every deadcase *messagingv1alpha1.<Kind>:; kept thev1beta1cases.workloadLifecyclePoliciesnow returns the inline-embeddedmessagingv1beta1.WorkloadLifecyclePoliciesdirectly (dropped redundant string casts —unconvert).messagingv1beta1.*acrossreconcile_shared.go,adoption_policy.go,lifecycle_policy.go,drift_policy.go,events.go,suspend.go.internal/validation/: all validators flipped to v1beta1 types.ValidateConnectionRefcollapsed a v1beta1-first/v1alpha1-fallback double-Get into a single Get.listConnectionDependentsdropped the now-dead cross-version double-List + dedup (a single-version List can't return duplicates); one List per kind.*_test.go) flipped to v1beta1 fixtures. Cross-version dedup tests whose entire premise was v1alpha1+v1beta1 serving one stored object were removed (live delete-blocked behavior still covered byTestValidateQueueManagerConnectionDeleteWithV1Beta1Dependents); a single-version multi-kind order test replaces them. The AUTH-14 auth-preservation guard inqueuemanagerconnection_native_v1beta1_test.gois kept; only the now-vacuous "no v1alpha1 write" recorder was dropped.cmd/main.go+ stale doc comments scrubbed.API coverage (roast P1)
Deleting the fuzz-heavy
api/v1alpha1shifted the./api/...denominator to v1beta1 only, dropping it to 72.4% — below the 75% HARD floor. Addedapi/v1beta1/deepcopy_nested_test.go(value-receiverDeepCopy()on every standalone type + a fully-populated QMCDeepCopyObjectround trip exercising the nested-pointer branches). api coverage 72.4% -> 92.5%. Floor not lowered.Gates
task verify(codegen-clean): ok — no CRD change (single-version since 8e-8a)task lint+arch:lint: 0 issues (initial red was the known golangci stale-cache flake + a sibling-worktree leak; clean aftercache clean)task test:run: internal 92.6% (floor 90), api 92.5% (floor 75)task scrub/scrub:tree: ok (542 files clean)task format:check: okgo build ./...,go vet ./...,go vet -tags e2e ./...,go vet -tags integration ./...: cleangrep -rn "v1alpha1" internal/ api/ cmd/= 0e2e (kustomize)+ helm-e2e.Draft — do not self-merge; awaiting independent review + CI.