Skip to content

Add strict password policy - #21

Merged
NeOMakinG merged 3 commits into
PrestaShop:developfrom
NeOMakinG:add-password-policy
Jul 8, 2022
Merged

Add strict password policy#21
NeOMakinG merged 3 commits into
PrestaShop:developfrom
NeOMakinG:add-password-policy

Conversation

@NeOMakinG

Copy link
Copy Markdown
Questions Answers
Description? We need to apply a some JS in order to show password policy tips
Type? new feature
BC breaks? no
Deprecations? no
How to test? Go on register as a customer, type your password and have fun!
Possible impacts? Register as a customer

@jolelievre
jolelievre marked this pull request as ready for review June 9, 2022 07:54
@florine2623 florine2623 self-assigned this Jun 13, 2022

@florine2623 florine2623 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @NeOMakinG ,

I have tested multiple cases :
use of only letters, mix of upper and lower cases
only digits
mix of letters and digits
special characters
mix of letters, digits and special characters
use of spaces
use of real words/use of series of letters
repetition of a word
use of a sequence like "abc" or "123"
use of dates
use of @ to replace a, use of 3 to replace E

I have found an issue :

  • When I type a password with ^ character, it won't type in the field. But if I click on SHOW the password, I can type the character ^ it with no issue.
    Same behavior with character ` and ¨
Screen.Recording.2022-06-15.at.09.26.35.mov

Could you check ?
Thanks!

@sLorenzini

Copy link
Copy Markdown
Contributor

Hello @NeOMakinG ,

I have tested multiple cases : use of only letters, mix of upper and lower cases only digits mix of letters and digits special characters mix of letters, digits and special characters use of spaces use of real words/use of series of letters repetition of a word use of a sequence like "abc" or "123" use of dates use of @ to replace a, use of 3 to replace E

I have found an issue :

* When I type a password with `^` character, it won't type in the field. But if I click on SHOW the password, I can type the character `^` it with no issue.
  Same behavior with character ` and  ¨

Screen.Recording.2022-06-15.at.09.26.35.mov

Could you check ? Thanks!

hello @NeOMakinG,

I've tested the same cases on hide/show password as @florine2623. All good
But I reproduce the same issue as @florine2623.
My screenrecord:

password-characters.mp4

Here's are the characters to test for the issue: ¨, ^, `

Could you check please 🙏?

Thanks

@NeOMakinG
NeOMakinG force-pushed the add-password-policy branch from 2dcbe74 to 2eede13 Compare July 7, 2022 12:04
@NeOMakinG

NeOMakinG commented Jul 7, 2022

Copy link
Copy Markdown
Author

@sLorenzini @florine2623 https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/password

This is a normal behavior, test on a regular password input and you'll notice it, I guess we don't have the power to do anything to this, you can also test on the demo of prestashop, it will do the same thing!

@florine2623 florine2623 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @NeOMakinG ,

Ok, noted, thanks for the details ^^

Tested again on develop and 8.0.x, on connection page and order as a guest page.

Looking good to me.
It is QA ✅

@florine2623 florine2623 added QA ✔️ Status: Check done, Code approved and removed Waiting for QA labels Jul 7, 2022
@NeOMakinG
NeOMakinG merged commit 5997f51 into PrestaShop:develop Jul 8, 2022
@NeOMakinG

Copy link
Copy Markdown
Author

Thanks @florine2623 and @sLorenzini for your time and everyone for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA ✔️ Status: Check done, Code approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants