Skip to content

meta_tensor orientation#4278

Merged
wyli merged 5 commits into
Project-MONAI:feature/MetaTensorfrom
rijobro:MetaTensor_Orientation
May 17, 2022
Merged

meta_tensor orientation#4278
wyli merged 5 commits into
Project-MONAI:feature/MetaTensorfrom
rijobro:MetaTensor_Orientation

Conversation

@rijobro

@rijobro rijobro commented May 16, 2022

Copy link
Copy Markdown
Contributor

Description

Orientation and Orientationd work with MetaTensor.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • In-line docstrings updated.

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
rijobro requested review from Nic-Ma, ericspod and wyli May 16, 2022 11:34
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Comment thread monai/transforms/spatial/array.py
rijobro added 3 commits May 16, 2022 14:09
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@wyli @ericspod do you have any comments?

Thanks.

@wyli

wyli commented May 17, 2022

Copy link
Copy Markdown
Contributor

since we are on the refactoring, shall we tackle these as well #1749 and #3805 I'm looking into the APIs.

@rijobro

rijobro commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

Under the new proposal, transforms would be torch only, so #3805 becomes invalid. We can certainly do #1749.

@rijobro

rijobro commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

Can I do #1749 as a follow up PR?

@wyli
wyli merged commit b20c025 into Project-MONAI:feature/MetaTensor May 17, 2022
@wyli

wyli commented May 17, 2022

Copy link
Copy Markdown
Contributor

sure, merging this one for now. I think part of #3805 for separating metadict and array functions is still valid, and in the near future we want to support the bounding boxes types...

@rijobro
rijobro deleted the MetaTensor_Orientation branch May 19, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants