Skip to content

add box ops for affine and zoom#4307

Merged
wyli merged 9 commits into
Project-MONAI:devfrom
Can-Zhao:box_ops
May 22, 2022
Merged

add box ops for affine and zoom#4307
wyli merged 9 commits into
Project-MONAI:devfrom
Can-Zhao:box_ops

Conversation

@Can-Zhao

@Can-Zhao Can-Zhao commented May 20, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: Can Zhao canz@nvidia.com

Fixes #3572 .

Description

add box_ops for zoom box transforms
tested with detection training pipeline

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao

Copy link
Copy Markdown
Collaborator Author

/black

@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 20, 2022
@Can-Zhao
Can-Zhao requested review from Nic-Ma and wyli May 20, 2022 14:12

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please see some minor comments inline. cc @Nic-Ma

Comment thread monai/apps/detection/transforms/box_ops.py
Comment thread monai/apps/detection/transforms/box_ops.py Outdated
Comment thread monai/apps/detection/transforms/box_ops.py
Comment thread monai/apps/detection/transforms/box_ops.py Outdated
Can-Zhao and others added 5 commits May 20, 2022 16:48
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
Can-Zhao marked this pull request as ready for review May 20, 2022 23:17
@Can-Zhao
Can-Zhao requested a review from wyli May 20, 2022 23:18
@Can-Zhao Can-Zhao changed the title add box_ops for zoom box transforms add zoom box transforms May 20, 2022
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
Can-Zhao enabled auto-merge (squash) May 20, 2022 23:34
@Can-Zhao Can-Zhao changed the title add zoom box transforms add box ops for affine and zoom May 20, 2022
@Can-Zhao

Copy link
Copy Markdown
Collaborator Author

/build

1 similar comment
@Can-Zhao

Copy link
Copy Markdown
Collaborator Author

/build

@Nic-Ma

Nic-Ma commented May 22, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli disabled auto-merge May 22, 2022 08:58
@wyli
wyli enabled auto-merge (squash) May 22, 2022 08:58
@wyli

wyli commented May 22, 2022

Copy link
Copy Markdown
Contributor

/build

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented May 22, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli disabled auto-merge May 22, 2022 09:43
@wyli
wyli enabled auto-merge (squash) May 22, 2022 09:43
@wyli
wyli merged commit 98adb50 into Project-MONAI:dev May 22, 2022
@wyli wyli mentioned this pull request May 22, 2022
@Can-Zhao
Can-Zhao deleted the box_ops branch May 22, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Box transforms

3 participants