Skip to content

7540 change bundle workflow args - #7549

Merged
KumoLiu merged 22 commits into
Project-MONAI:devfrom
yiheng-wang-nv:add-bundleworkflow-arg
Apr 1, 2024
Merged

7540 change bundle workflow args#7549
KumoLiu merged 22 commits into
Project-MONAI:devfrom
yiheng-wang-nv:add-bundleworkflow-arg

Conversation

@yiheng-wang-nv

@yiheng-wang-nv yiheng-wang-nv commented Mar 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #7540 .

Description

This PR:

  1. add logging file and meta file into BundleWorkflow
  2. add the sequence form of meta files check for ConfigWorkflow

Types of changes

  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

yiheng-wang-nv and others added 4 commits March 15, 2024 14:25
@yiheng-wang-nv
change bundle workflow args
a5d5ed3 
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
Merge branch 'dev' into add-bundleworkflow-arg
0d8bb5c
@yiheng-wang-nv
finish implement and add test cases
cf082da 
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
Merge branch 'add-bundleworkflow-arg' of github.com:yiheng-wang-nv/MO…
104db20 
…NAI into add-bundleworkflow-arg
@yiheng-wang-nv
yiheng-wang-nv marked this pull request as ready for review March 20, 2024 05:35
@yiheng-wang-nv
yiheng-wang-nv requested review from KumoLiu and wyli March 20, 2024 05:36
@yiheng-wang-nv
fix mypy error
46a8c67 
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
autofix
3fbe598 
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
yiheng-wang-nv requested a review from Nic-Ma March 20, 2024 07:23
ericspod
ericspod reviewed Mar 21, 2024
View reviewed changes
Comment thread monai/bundle/workflows.py Outdated
ericspod
ericspod reviewed Mar 21, 2024
View reviewed changes
Comment thread monai/bundle/workflows.py Outdated
ericspod
ericspod reviewed Mar 21, 2024
View reviewed changes
Comment thread monai/bundle/workflows.py Outdated
ericspod
ericspod reviewed Mar 21, 2024
View reviewed changes
Comment thread monai/bundle/workflows.py Outdated
yiheng-wang-nv and others added 7 commits March 25, 2024 18:08
@yiheng-wang-nv
use isfile
ccc2364 
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
Merge branch 'dev' into add-bundleworkflow-arg
7895b59
@yiheng-wang-nv
resolve comment of meta_file
f793e80 
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
Merge branch 'add-bundleworkflow-arg' of github.com:yiheng-wang-nv/MO…
f0e52b8 
…NAI into add-bundleworkflow-arg
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
63717ae 
for more information, see https://pre-commit.ci
@yiheng-wang-nv
remove unused lib
cf307c3 
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
Merge branch 'add-bundleworkflow-arg' of github.com:yiheng-wang-nv/MO…
bca11a5 
…NAI into add-bundleworkflow-arg
ericspod
ericspod approved these changes Mar 26, 2024
View reviewed changes

@ericspod ericspod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@KumoLiu

KumoLiu commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

For the CI error, may add something like this:

MONAI/monai/bundle/workflows.py

Line 171 in bca11a5

def get_workflow_type(self):

@KumoLiu

KumoLiu commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

/build

@KumoLiu

KumoLiu commented Apr 1, 2024

Copy link
Copy Markdown
Contributor

/build

@KumoLiu
KumoLiu enabled auto-merge (squash) April 1, 2024 07:51
@KumoLiu
KumoLiu merged commit c885100 into Project-MONAI:dev Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericspod ericspod ericspod approved these changes
@KumoLiu KumoLiu Awaiting requested review from KumoLiu KumoLiu is a code owner
@wyli wyli Awaiting requested review from wyli
@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add args in BundleWorkflow

3 participants

@yiheng-wang-nv @KumoLiu @ericspod