Adding Tailored ControlNet Implementations into Generative Model Application - #7875
Merged
mingxin-zheng merged 25 commits intoJul 1, 2024
Merged
Conversation
KumoLiu
reviewed
Jun 25, 2024
KumoLiu
reviewed
Jun 25, 2024
guopengf
force-pushed
the
fix-issue-7874-add-controlnet
branch
from
June 25, 2024 22:38
7e2a8b0 to
52428b0
Compare
guopengf
marked this pull request as ready for review
June 26, 2024 02:34
KumoLiu
reviewed
Jun 26, 2024
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
for more information, see https://pre-commit.ci Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
…ct-MONAI#7847) Fixes Project-MONAI#7677 . ### Description A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. --------- Signed-off-by: alkamid <adam.klimont@cydar.co.uk> Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Pengfei Guo <32000655+guopengf@users.noreply.github.com> Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
guopengf
force-pushed
the
fix-issue-7874-add-controlnet
branch
from
June 26, 2024 19:15
3afc58d to
c342b23
Compare
Contributor
|
Hi @ericspod @Nic-Ma @mingxin-zheng, if you don't have more comments on this one, I will try to trigger more tests and merge this one. Thanks! |
Contributor
|
Hi @guopengf, could you please help solve the conflict then I will try to merge this PR, thanks! |
Signed-off-by: Pengfei Guo <32000655+guopengf@users.noreply.github.com>
Contributor
Author
Done, thanks! |
Contributor
|
/build |
KumoLiu
approved these changes
Jun 28, 2024
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Contributor
|
/build |
Contributor
|
/build |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Contributor
|
/build |
Contributor
|
Add Do you have any insights on this one? @ericspod @Nic-Ma @mingxin-zheng |
Collaborator
It seems the error is caused by this line: ControlNet, has_controlnet = optional_import("generative.networks.nets.controlnet", name="ControlNet") |
Collaborator
|
Update: pinpointed that removing will solve the issue @KumoLiu |
Contributor
|
/build |
for more information, see https://pre-commit.ci
mingxin-zheng
approved these changes
Jul 1, 2024
mingxin-zheng
left a comment
mingxin-zheng
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me.
Collaborator
|
I am merging this to unblock #7861. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7874.
Description
Integrating a tailored ControlNet model into the generative model application to enable the training using high-dimensional 3D images (up to 512 x 512 x 768).
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.