Skip to content

Stop using method swizzling for registering CurrentTestCaseTracker to XCTestObservationCenter - #741

Merged
ikesyo merged 2 commits into
masterfrom
avoid-method-swizzling
May 8, 2020
Merged

Stop using method swizzling for registering CurrentTestCaseTracker to XCTestObservationCenter#741
ikesyo merged 2 commits into
masterfrom
avoid-method-swizzling

Conversation

@ikesyo

@ikesyo ikesyo commented May 6, 2020

Copy link
Copy Markdown
Member

The weird workaround is no longer needed in recent Xcode versions (at least Xcode 10.1 or later).

Fixes #740, see it for the details.

refs: #278, #273, #271

@ikesyo
ikesyo force-pushed the avoid-method-swizzling branch 2 times, most recently from 7f1c973 to 0dce79d Compare May 6, 2020 14:56
@ikesyo

ikesyo commented May 8, 2020

Copy link
Copy Markdown
Member Author

@mark-anders Could you try with this branch?

@ikesyo
ikesyo force-pushed the avoid-method-swizzling branch 2 times, most recently from f5881d4 to 60d3c75 Compare May 8, 2020 15:22
@ikesyo

ikesyo commented May 8, 2020

Copy link
Copy Markdown
Member Author

I confirmed that this works well 🚢

@ikesyo
ikesyo force-pushed the avoid-method-swizzling branch from 60d3c75 to 0ed8b9b Compare May 8, 2020 15:28
… XCTestObservationCenter

The weird workaround is no longer needed in recent Xcode versions (at least Xcode 10.1 or later).
@ikesyo
ikesyo force-pushed the avoid-method-swizzling branch 3 times, most recently from ddd721d to 8fcb419 Compare May 8, 2020 16:20
@ikesyo
ikesyo force-pushed the avoid-method-swizzling branch from 8fcb419 to 0d07988 Compare May 8, 2020 16:24
@ikesyo

ikesyo commented May 8, 2020

Copy link
Copy Markdown
Member Author

Suffering from actions/runner-images#841.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing tests throw NSInternalInconsistencyException when using AppCode

1 participant